Skip to content

Fix select.select list construction #8247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moreal wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Draft

Fix select.select list construction #8247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Lib/test/test_select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def test_errno(self):
else:
self.fail("exception not raised")

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: unexpectedly identical: []
def test_returned_list_identity(self):
# See issue #8329
r, w, x = select.select([], [], [], 1)
Expand Down
7 changes: 5 additions & 2 deletions crates/stdlib/src/select.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ mod decl {
let (xlist, mut x) = seq2set(&xlist)?;

if rlist.is_empty() && wlist.is_empty() && xlist.is_empty() {
let empty = vm.ctx.new_list(vec![]);
return Ok((empty.clone(), empty.clone(), empty));
return Ok((
vm.ctx.new_list(vec![]),
vm.ctx.new_list(vec![]),
vm.ctx.new_list(vec![]),
));
}

let nfds = cfg_select! {
Expand Down
Loading