Skip to content

Add memoryview support to c-api #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bschoenmaeckers wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −0
Open

Add memoryview support to c-api #8240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/capi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ pub mod genericaliasobject;
pub mod import;
pub mod listobject;
pub mod longobject;
pub mod memoryobject;
pub mod methodobject;
pub mod moduleobject;
pub mod object;
Expand Down
37 changes: 37 additions & 0 deletions crates/capi/src/memoryobject.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
use crate::object::define_py_check;
use crate::{PyObject, pystate::with_vm};
use rustpython_vm::PyPayload;
use rustpython_vm::builtins::PyMemoryView;

define_py_check!(fn PyMemoryView_Check, types.memoryview_type);

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMemoryView_FromObject(obj: *mut PyObject) -> *mut PyObject {
with_vm(|vm| {
let obj = unsafe { &*obj };
Ok(PyMemoryView::from_object(obj, vm)?.into_ref(&vm.ctx))
})
}

#[cfg(test)]
mod tests {
use pyo3::prelude::*;
use pyo3::types::{PyBytes, PyMemoryView};

#[test]
fn memoryview_from_bytes() {
Python::attach(|py| {
let bytes = PyBytes::new(py, b"hello");
let view = PyMemoryView::from(&bytes).unwrap();

assert!(view.is_instance_of::<PyMemoryView>());

let copied = view
.call_method1("tobytes", ())
.unwrap()
.cast_into::<PyBytes>()
.unwrap();
assert_eq!(copied.as_bytes(), b"hello");
})
}
}
Loading