Skip to content

Add garbage collection c-api#8239

Open
bschoenmaeckers wants to merge 1 commit into
RustPython:mainfrom
bschoenmaeckers:c-api-gc
Open

Add garbage collection c-api#8239
bschoenmaeckers wants to merge 1 commit into
RustPython:mainfrom
bschoenmaeckers:c-api-gc

Conversation

@bschoenmaeckers

@bschoenmaeckers bschoenmaeckers commented Jul 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added support for additional object and garbage-collection APIs.
    • Exposed new memory allocation helpers for object-related use cases.
    • Made object finalization status available through the public API.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: e0a98f00-9d24-4f0f-9bc1-8c0d236cf7b5

📥 Commits

Reviewing files that changed from the base of the PR and between c41180d and 7e34cc2.

📒 Files selected for processing (3)
  • crates/capi/src/lib.rs
  • crates/capi/src/objimpl.rs
  • crates/vm/src/object/core.rs
📝 Walkthrough

Walkthrough

Adds a new public objimpl module in the capi crate providing C-ABI-compatible functions for GC object tracking, GC collection control, and raw memory allocation, delegating to the VM's GC state and memory routines. Also makes PyObject::gc_finalized publicly visible to support this.

Changes

objimpl C-API module

Layer / File(s) Summary
Module wiring and gc_finalized visibility
crates/capi/src/lib.rs, crates/vm/src/object/core.rs		 Registers the new objimpl module and changes PyObject::gc_finalized visibility from pub(crate) to pub.
GC tracking and control extern functions
crates/capi/src/objimpl.rs		 Adds PyObject_GC_Track, PyObject_GC_UnTrack, PyObject_GC_IsTracked, PyObject_GC_IsFinalized operating on GC state via with_vm, plus PyGC_Collect, PyGC_Enable, PyGC_Disable, PyGC_IsEnabled.
Memory allocation wrappers
crates/capi/src/objimpl.rs		 Adds PyObject_Malloc, PyObject_Calloc, PyObject_Realloc, PyObject_Free delegating to PyMem_* allocator functions.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested reviewers: ShaharNaveh, youknowone

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding GC-related Python C-API bindings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bschoenmaeckers @ShaharNaveh