crates/capi/src/pyframe.rs (2)

6-11: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Reuse Frame::f_code() instead of touching the field directly.

crates/vm/src/builtins/frame.rs already exposes a public accessor for this: The Frame f_code accessor returns self.code.clone(). Calling frame.f_code() here avoids depending on the code field's visibility/shape directly from another crate and keeps a single source of truth if the accessor logic ever changes.

♻️ Proposed refactor

     with_vm(|vm| {
         let frame = unsafe { &*frame }.try_downcast_ref::<Frame>(vm)?;
-        Ok(frame.code.clone())
+        Ok(frame.f_code())
     })

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/capi/src/pyframe.rs` around lines 6 - 11, Refactor PyFrame_GetCode to
use the public Frame::f_code() accessor instead of cloning frame.code directly.
In the PyFrame_GetCode function, keep the existing try_downcast_ref::<Frame>(vm)
lookup, then call frame.f_code() to obtain the code object so this crate depends
on the accessor rather than the Frame field layout. This keeps the
implementation aligned with the Frame API in builtins::frame::Frame and
preserves a single source of truth for code retrieval.

---

14-24: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicated line-number logic — reuse Frame::f_lineno().

This re-implements the exact branching already defined publicly on Frame: f_lineno selects first_line_number when lasti()==0, otherwise uses current_location().line.get(). The lasti()==0 guard exists specifically to avoid an underflow in current_location()'s locations[self.lasti()-1] indexing — duplicating this here risks silent divergence if that VM-side logic is ever changed (e.g. bug fix, edge-case handling) without updating this copy.

♻️ Proposed refactor

     with_vm(|vm| {
         let frame = unsafe { &*frame }.try_downcast_ref::<Frame>(vm)?;
-        let lineno = if frame.lasti() == 0 {
-            frame.code.first_line_number.map_or(1, |n| n.get())
-        } else {
-            frame.current_location().line.get()
-        };
-        Ok(lineno as core::ffi::c_int)
+        Ok(frame.f_lineno() as core::ffi::c_int)
     })

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/capi/src/pyframe.rs` around lines 14 - 24, Replace the duplicated
line-number branching in PyFrame_GetLineNumber with the existing
Frame::f_lineno() logic instead of re-implementing the
lasti()/first_line_number/current_location() check here. Keep the unsafe frame
cast and VM lookup in PyFrame_GetLineNumber, but delegate the actual line-number
retrieval to Frame::f_lineno() so this C API entry point stays consistent with
the Frame method and won’t drift if the VM-side behavior changes.