Skip to content

Tuple Support and WIP Object Support in JIT #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuigiTheJokesterAlvarez wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Tuple Support and WIP Object Support in JIT #8188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
976e2ee
partial tuple support in jit
LuigiTheJokesterAlvarez Jun 28, 2026
1d15570
rebinding fix
LuigiTheJokesterAlvarez Jun 28, 2026
1996657
successful return tuple
LuigiTheJokesterAlvarez Jun 28, 2026
2d7483c
delete test
LuigiTheJokesterAlvarez Jun 28, 2026
bdf64b7
AAAAAAAAAAA
LuigiTheJokesterAlvarez Jun 28, 2026
f32149d
documentation
LuigiTheJokesterAlvarez Jun 29, 2026
f2fb6ef
Fixed it after 3038 years
LuigiTheJokesterAlvarez Jul 2, 2026
661b659
Merge branch 'main' of https://github.com/RustPython/RustPython into …
LuigiTheJokesterAlvarez Jul 2, 2026
c12d905
test snippet fix + doc error
LuigiTheJokesterAlvarez Jul 2, 2026
a26972c
why on earth do i always forget about formatting
LuigiTheJokesterAlvarez Jul 2, 2026
35214d1
alegremente
LuigiTheJokesterAlvarez Jul 2, 2026
1a2f502
Disabled the While Loop Test until good implementation of SSA phi nodes
LuigiTheJokesterAlvarez Jul 3, 2026
55895a0
clippy
LuigiTheJokesterAlvarez Jul 3, 2026
ec7eedb
onelineofcode
LuigiTheJokesterAlvarez Jul 3, 2026
60b12a9
AAAAAAAARGH
LuigiTheJokesterAlvarez Jul 3, 2026
3f9c312
ruff
LuigiTheJokesterAlvarez Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebinding fix
  • Loading branch information
@LuigiTheJokesterAlvarez
LuigiTheJokesterAlvarez committed Jun 28, 2026
commit 1d155702709fe9ae9e6dfc5d1ee7ce63e0ae4659
49 changes: 7 additions & 42 deletions crates/jit/src/instructions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,49 +180,14 @@ impl<'a, 'b> FunctionCompiler<'a, 'b> {
}

fn store_variable(&mut self, idx: oparg::VarNum, val: JitValue) -> Result<(), JitCompileError> {
#[expect(clippy::mut_mut, reason = "This seems like a false positive")]
let builder = &mut self.builder;
match val {
JitValue::Tuple(elements) => {
let val = JitValue::Tuple(elements);
match &self.variables[idx] {
Some(existing @ Local::Tuple { .. }) => {
// reuse existing vars
Self::update_local(builder, existing, val)
}
Some(Local::Scalar { .. }) => Err(JitCompileError::NotSupported),
None => {
let local = Self::local_from_value(builder, val)?;
self.variables[idx] = Some(local);
Ok(())
}
}
}
_ => {
// primitive
let vty = val.to_jit_type().ok_or(JitCompileError::NotSupported)?;
let local = self.variables[idx].get_or_insert_with(|| {
let var = builder.declare_var(vty.to_cranelift());
Local::Scalar {
var,
ty: vty.clone(),
}
});

match local {
Local::Scalar { var, ty } => {
if vty != *ty {
Err(JitCompileError::NotSupported)
} else {
self.builder.def_var(*var, val.into_value().unwrap());
Ok(())
}
}
_ => Err(JitCompileError::NotSupported)
}
}
#[expect(clippy::mut_mut, reason = "This seems like a false positive")]
let builder = &mut self.builder;

let local = Self::local_from_value(builder, val)?;
self.variables[idx] = Some(local);

Ok(())
}
}

fn boolean_val(&mut self, val: JitValue) -> Result<Value, JitCompileError> {
match val {
Expand Down
1 change: 1 addition & 0 deletions testo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ def foo():
(3, 4),
1
)
t = 1
return 3

foo.__jit__()
Expand Down