Clean up compiler parity leftovers#8174
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe PR removes one codegen error variant, adds optional source locations to symbols, records them for global and nonlocal declarations, uses them in symbol-table validation, and passes synthesized source text into AST compile syntax errors. ChangesSource-location error reporting
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
marked this pull request as ready for review
June 26, 2026 12:38
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/codegen/src/symboltable.rs`:
- Around line 3361-3363: The global/nonlocal handling in symbol registration is
using the statement-wide range instead of each identifier’s own range, so errors
for later names point to the wrong place. Update the `Stmt::Global` and
`Stmt::Nonlocal` call sites in `symboltable.rs` to pass each name’s range (or
use `register_ident(name, ...)` for per-name registration) rather than
`statement.range()`. Keep the change aligned with the
`register_ident`/`symbol.location` flow so each declared name gets its own
location.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: d89dab1f-1a63-483d-9e25-0a7e4d36bab9
📒 Files selected for processing (3)
crates/codegen/src/error.rscrates/codegen/src/symboltable.rscrates/vm/src/stdlib/_ast.rs
💤 Files with no reviewable changes (1)
- crates/codegen/src/error.rs
Comment on lines
+3361
to
+3363
| if matches!(role, SymbolUsage::Global | SymbolUsage::Nonlocal) { | ||
| symbol.location = location; | ||
| } |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Store the per-name range for global/nonlocal declarations.
Line 3361 now persists the passed location, but the Stmt::Global/Stmt::Nonlocal callers pass statement.range() for every declared name. For nonlocal a, b, an error for b will point at the statement start instead of the offending identifier. Prefer calling register_ident(name, ...) or passing name.range.
Suggested fix
- self.register_name(name.as_str(), SymbolUsage::Global, statement.range())?;
+ self.register_ident(name, SymbolUsage::Global)?;
- self.register_name(
- name.as_str(),
- SymbolUsage::Nonlocal,
- statement.range(),
- )?;
+ self.register_ident(name, SymbolUsage::Nonlocal)?;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/codegen/src/symboltable.rs` around lines 3361 - 3363, The
global/nonlocal handling in symbol registration is using the statement-wide
range instead of each identifier’s own range, so errors for later names point to
the wrong place. Update the `Stmt::Global` and `Stmt::Nonlocal` call sites in
`symboltable.rs` to pass each name’s range (or use `register_ident(name, ...)`
for per-name registration) rather than `statement.range()`. Keep the change
aligned with the `register_ident`/`symbol.location` flow so each declared name
gets its own location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #8138
Summary by CodeRabbit