Skip to content

perf: use interned name in generic_getattr_opt #8129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharifhsn wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

perf: use interned name in generic_getattr_opt #8129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/vm/src/protocol/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ impl PyObject {
dict: Option<PyDictRef>,
vm: &VirtualMachine,
) -> PyResult<Option<PyObjectRef>> {
let name = name_str.as_wtf8();
let obj_cls = self.class();
let cls_attr_name = vm.ctx.interned_str(name_str);
let cls_attr = match cls_attr_name.and_then(|name| obj_cls.get_attr(name)) {
Expand All @@ -251,7 +250,9 @@ impl PyObject {
let dict = dict.or_else(|| self.dict());

let attr = if let Some(dict) = dict {
dict.get_item_opt(name, vm)?
// Look up by the `PyStr` object (cached hash + pointer-equality fast
// path) rather than its `&Wtf8` content, which re-hashes every call.
dict.get_item_opt(name_str, vm)?
} else {
None
};
Expand Down
Loading