Skip to content

cleanup the signals module #8076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jun 12, 2026
Merged

cleanup the signals module #8076

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
572b253
Initital cleanup
ShaharNaveh Jun 11, 2026
62f3560
More cleanup
ShaharNaveh Jun 11, 2026
18ba484
coderabbit suggestion
ShaharNaveh Jun 11, 2026
aaba3fa
clippy
ShaharNaveh Jun 11, 2026
b44f3d8
Merge remote-tracking branch 'upstream/main' into CLN-signal
ShaharNaveh Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
coderabbit suggestion
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jun 11, 2026
commit 18ba4842e9cc28daecf4422cc77d087da5d64aae
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/_signal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ pub(crate) mod _signal {
.ok_or_else(|| {
vm.new_value_error(format!(
"signal number out of range [1, {}]",
SIGNUM_RANGE.end
SIGNUM_RANGE.end - 1
))
Comment thread
ShaharNaveh marked this conversation as resolved.
})?;

Expand Down
Loading