Skip to content

Upgrade pkcs8 to 0.11#7977

Open
ShaharNaveh wants to merge 1 commit into
RustPython:mainfrom
ShaharNaveh:upgrade-pkcs8-0-11
Open

Upgrade pkcs8 to 0.11#7977
ShaharNaveh wants to merge 1 commit into
RustPython:mainfrom
ShaharNaveh:upgrade-pkcs8-0-11

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented May 25, 2026 •
edited by coderabbitai Bot
Loading

closes #7976

Summary by CodeRabbit

  • Chores
    • Updated pkcs8 workspace dependency from version 0.10 to 0.11
    • Updated internal SSL certificate handling code to align with the new dependency version

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7c1ed291-c406-42fd-8bee-8a5037408ff6

📥 Commits

Reviewing files that changed from the base of the PR and between a5775e0 and 93ad4e0.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • crates/stdlib/src/ssl/cert.rs
📝 Walkthrough

Walkthrough

This PR upgrades the pkcs8 workspace dependency from version 0.10 to 0.11 and updates the SSL certificate loading logic to use the new API, switching from the owned EncryptedPrivateKeyInfo type to the borrowed EncryptedPrivateKeyInfoRef for encrypted PKCS#8 key parsing.

Changes

PKCS#8 Version Migration

Layer / File(s) Summary
PKCS#8 upgrade and encrypted key parsing migration
Cargo.toml, crates/stdlib/src/ssl/cert.rs		 Workspace dependency pkcs8 bumped to 0.11. Encrypted private key parsing in load_cert_chain_from_file updated from EncryptedPrivateKeyInfo::try_from() to EncryptedPrivateKeyInfoRef::try_from() with matching import changes.

🎯 2 (Simple) | ⏱️ ~8 minutes

🐰 A tiny hop through the crypto stack,
From Info to InfoRef—a backward-compat attack!
Version bumps and borrowed references align,
PKCS#8 keys now dance in the zero-copy line! 🔐

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: upgrading the pkcs8 dependency from 0.10 to 0.11.
Linked Issues check ✅ Passed The PR successfully upgrades pkcs8 to 0.11 by updating Cargo.toml and adjusting code to use EncryptedPrivateKeyInfoRef instead of EncryptedPrivateKeyInfo, meeting the linked issue #7976 requirements.
Out of Scope Changes check ✅ Passed All changes are directly related to the pkcs8 0.10 to 0.11 upgrade: dependency version bump and necessary code adjustments for API compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review May 25, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone