Skip to content

Add capsule support to c-api #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
May 26, 2026
Merged

Add capsule support to c-api #7940

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79606ee
Add capsule support to c-api
bschoenmaeckers May 20, 2026
badf325
Review
bschoenmaeckers May 22, 2026
45f697b
Add `pycapsule` to dictionary
bschoenmaeckers May 22, 2026
a34acf0
Review
bschoenmaeckers May 22, 2026
3b516f7
Disable tests
bschoenmaeckers May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review
  • Loading branch information
@bschoenmaeckers
bschoenmaeckers committed May 26, 2026
commit a34acf08074048a54b6e8c5bfda197c13622bc98
10 changes: 8 additions & 2 deletions crates/capi/src/pycapsule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ pub unsafe extern "C" fn PyCapsule_GetContext(capsule: *mut PyObject) -> *mut c_
}
Comment thread
bschoenmaeckers marked this conversation as resolved.

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyCapsule_SetContext(capsule: *mut PyObject, context: *mut c_void) -> c_int {
pub unsafe extern "C" fn PyCapsule_SetContext(
capsule: *mut PyObject,
context: *mut c_void,
) -> c_int {
with_vm(|vm| {
let capsule = unsafe { &*capsule }
.downcast_ref_if_exact::<PyCapsule>(vm)
Expand All @@ -63,7 +66,10 @@ pub unsafe extern "C" fn PyCapsule_SetContext(capsule: *mut PyObject, context: *
}
Comment thread
bschoenmaeckers marked this conversation as resolved.

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyCapsule_SetPointer(capsule: *mut PyObject, pointer: *mut c_void) -> c_int {
pub unsafe extern "C" fn PyCapsule_SetPointer(
capsule: *mut PyObject,
pointer: *mut c_void,
) -> c_int {
with_vm(|vm| {
let capsule = unsafe { &*capsule }
.downcast_ref_if_exact::<PyCapsule>(vm)
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/capsule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl PyCapsule {
.store(context, core::sync::atomic::Ordering::Relaxed);
}

pub fn name(&self) -> Option<&'static CStr> {
pub fn name(&self) -> Option<&CStr> {
self.name
}

Expand Down
Loading