Skip to content

Add call functions to c-api #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
May 20, 2026
Merged

Add call functions to c-api #7937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a07d3dd
Add call functions to c-api
bschoenmaeckers May 20, 2026
6d47176
Review
bschoenmaeckers May 20, 2026
9530575
Move conversion impl to c-api
bschoenmaeckers May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cspell.dict/cpython.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ mult
multibytecodec
nameobj
nameop
nargsf
ncells
nconsts
newargs
Expand Down
113 changes: 113 additions & 0 deletions crates/capi/src/abstract_.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,118 @@
use crate::{PyObject, pystate::with_vm};
use alloc::slice;
use core::ffi::c_int;
use rustpython_vm::builtins::{PyDict, PyStr, PyTuple};
use rustpython_vm::function::{FuncArgs, KwArgs, PosArgs};
use rustpython_vm::{AsObject, Py, PyObjectRef, PyResult, VirtualMachine};

const PY_VECTORCALL_ARGUMENTS_OFFSET: usize = 1usize << (usize::BITS as usize - 1);

fn tuple_to_args(tuple: &Py<PyTuple>) -> PosArgs {
tuple.iter().cloned().collect::<Vec<_>>().into()
}

fn dict_to_kwargs(vm: &VirtualMachine, dict: &Py<PyDict>) -> PyResult<KwArgs> {
dict.items_vec()
.into_iter()
.map(|(key, value)| {
let key = key
.downcast_ref::<PyStr>()
.map(|s| s.to_string())
.ok_or_else(|| vm.new_type_error("keywords must be strings"))?;
Ok((key, value))
})
.collect::<PyResult<_>>()
.map(KwArgs::new)
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyObject_Call(
callable: *mut PyObject,
args: *mut PyObject,
kwargs: *mut PyObject,
) -> *mut PyObject {
with_vm(|vm| {
let callable = unsafe { &*callable };
let args = tuple_to_args(unsafe { &*args }.try_downcast_ref::<PyTuple>(vm)?);

let kwargs: Option<KwArgs> = unsafe { kwargs.as_ref() }
.map(|kwargs| dict_to_kwargs(vm, kwargs.try_downcast_ref::<PyDict>(vm)?))
.transpose()?;

callable.call_with_args(FuncArgs::new(args, kwargs.unwrap_or_default()), vm)
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyObject_CallNoArgs(callable: *mut PyObject) -> *mut PyObject {
with_vm(|vm| unsafe { &*callable }.call((), vm))
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyObject_Vectorcall(
callable: *mut PyObject,
args: *const *mut PyObject,
nargsf: usize,
kwnames: *mut PyObject,
) -> *mut PyObject {
with_vm(|vm| {
let num_positional_args = nargsf & !PY_VECTORCALL_ARGUMENTS_OFFSET;

let kwnames: Option<&[PyObjectRef]> = unsafe {
kwnames
.as_ref()
.map(|tuple| Ok(&***tuple.try_downcast_ref::<PyTuple>(vm)?))
.transpose()?
};

let args_len = num_positional_args + kwnames.map_or(0, <[PyObjectRef]>::len);
let args = if args_len == 0 {
Vec::new()
} else {
unsafe { slice::from_raw_parts(args, args_len) }
.iter()
.map(|arg| unsafe { &**arg }.to_owned())
.collect::<Vec<_>>()
};

let callable = unsafe { &*callable };
callable.vectorcall(args, num_positional_args, kwnames, vm)
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyObject_VectorcallMethod(
name: *mut PyObject,
args: *const *mut PyObject,
nargsf: usize,
kwnames: *mut PyObject,
) -> *mut PyObject {
with_vm(|vm| {
let args_len = nargsf & !PY_VECTORCALL_ARGUMENTS_OFFSET;

if args_len == 0 {
return Err(
vm.new_system_error("PyObject_VectorcallMethod called with no receiver".to_owned())
);
}

let (receiver, args) = unsafe { slice::from_raw_parts(args, args_len) }
.split_first()
.expect("args_len > 0 should guarantee a receiver");

let method_name = unsafe { (&*name).try_downcast_ref::<PyStr>(vm)? };
let callable = unsafe { (&**receiver).get_attr(method_name, vm)? };

Ok(unsafe {
PyObject_Vectorcall(
callable.as_object().as_raw().cast_mut(),
args.as_ptr(),
nargsf - 1,
kwnames,
)
})
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyObject_GetItem(obj: *mut PyObject, key: *mut PyObject) -> *mut PyObject {
Expand Down
Loading