Skip to content

Update NOP tests to 3.14.5#7902

Open
ShaharNaveh wants to merge 5 commits into
RustPython:mainfrom
ShaharNaveh:update-test-xx
Open

Update NOP tests to 3.14.5#7902
ShaharNaveh wants to merge 5 commits into
RustPython:mainfrom
ShaharNaveh:update-test-xx

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented May 17, 2026

Those tests should be skipped, thus a "NOP test".

The motivation of this PR is to mark those items as done at #6839

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (28)
  • Lib/test/test_asdl_parser.py is excluded by !Lib/**
  • Lib/test/test_clinic.py is excluded by !Lib/**
  • Lib/test/test_generated_cases.py is excluded by !Lib/**
  • Lib/test/test_peg_generator/__init__.py is excluded by !Lib/**
  • Lib/test/test_peg_generator/__main__.py is excluded by !Lib/**
  • Lib/test/test_peg_generator/test_c_parser.py is excluded by !Lib/**
  • Lib/test/test_peg_generator/test_first_sets.py is excluded by !Lib/**
  • Lib/test/test_peg_generator/test_grammar_validator.py is excluded by !Lib/**
  • Lib/test/test_peg_generator/test_pegen.py is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/ascii-escapes.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/comments.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/comments.py is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/custom_keywords.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/custom_keywords.py is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/docstrings.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/docstrings.py is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/escapes.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/messages.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/messages.py is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/multiple_keywords.pot is excluded by !Lib/**
  • Lib/test/test_tools/i18n_data/multiple_keywords.py is excluded by !Lib/**
  • Lib/test/test_tools/test_compute_changes.py is excluded by !Lib/**
  • Lib/test/test_tools/test_i18n.py is excluded by !Lib/**
  • Lib/test/test_tools/test_makefile.py is excluded by !Lib/**
  • Lib/test/test_tools/test_msgfmt.py is excluded by !Lib/**
  • Lib/test/test_type_cache.py is excluded by !Lib/**
  • Lib/test/test_xxlimited.py is excluded by !Lib/**
  • Lib/test/test_xxtestfuzz.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 5915515c-04f3-4b43-985d-4bb417561b74

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
Copy link
Copy Markdown
Member

youknowone commented May 17, 2026

is this worth to do? we can simply add blocklist for #6839 too

@ShaharNaveh
Copy link
Copy Markdown
Contributor Author

ShaharNaveh commented May 17, 2026

is this worth to do? we can simply add blocklist for #6839 too

I think so, it will provide better tests if/when we'll have _testcapi for example

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026 •
edited
Loading

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_asdl_parser.py

dependencies:

dependent tests: (no tests depend on asdl_parser)

[x] test: cpython/Lib/test/test_xxtestfuzz.py

dependencies:

dependent tests: (no tests depend on xxtestfuzz)

[x] test: cpython/Lib/test/test_peg_generator

dependencies:

dependent tests: (no tests depend on peg_generator)

[x] test: cpython/Lib/test/test_clinic.py

dependencies:

dependent tests: (1 tests)

  • clinic: test_clinic

[x] test: cpython/Lib/test/test_type_cache.py

dependencies:

dependent tests: (no tests depend on type_cache)

[x] test: cpython/Lib/test/test_tools

dependencies:

dependent tests: (no tests depend on tools)

[x] test: cpython/Lib/test/test_generated_cases.py

dependencies:

dependent tests: (no tests depend on generated_cases)

[x] test: cpython/Lib/test/test_xxlimited.py

dependencies:

dependent tests: (no tests depend on xxlimited)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@ShaharNaveh ShaharNaveh marked this pull request as ready for review May 17, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone