Skip to content

Update test_xpickle.py to 3.14.5#7901

Merged
youknowone merged 1 commit into
RustPython:mainfrom
ShaharNaveh:update-test-xpickle
May 17, 2026
Merged

Update test_xpickle.py to 3.14.5#7901
youknowone merged 1 commit into
RustPython:mainfrom
ShaharNaveh:update-test-xpickle

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented May 17, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated dependency configuration for the pickle library group to improve test dependency management and organization.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 895aae2b-b16b-49fc-8263-cba52715f7a0

📥 Commits

Reviewing files that changed from the base of the PR and between f4f0350 and 89c00d9.

⛔ Files ignored due to path filters (2)
  • Lib/test/test_xpickle.py is excluded by !Lib/**
  • Lib/test/xpickle_worker.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • scripts/update_lib/deps.py
📝 Walkthrough

Walkthrough

This PR updates the manual dependency configuration in scripts/update_lib/deps.py for the pickle library group. The test file list is modified to reorder picklecommon.py and add test_xpickle.py and xpickle_worker.py as pickle test dependencies.

Changes

Pickle test dependencies configuration

Layer / File(s) Summary
Pickle test dependencies configuration
scripts/update_lib/deps.py		 The DEPENDENCIES["pickle"]["test"] list is reordered to reposition picklecommon.py and extended to include test_xpickle.py and xpickle_worker.py as test dependencies for the pickle library group.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • RustPython/RustPython#7895: Both PRs modify the pickle dependency group test file list by adding/repositioning picklecommon.py, with overlapping changes to the same configuration section.

Suggested reviewers

  • youknowone

Poem

A pickle's tale, now told with care,
Test files dance and reorder there—
Cross-pickle workers join the crew,
Dependencies sorted, fresh and new! 🥒✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to update a file to version 3.14.5, but the actual changes are dependency configuration updates for the pickle library group, including repositioning and adding test files. Revise the title to accurately reflect the main change, such as 'Add pickle test dependencies to manual dependency configuration' or 'Update pickle library test file dependencies'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_xpickle.py

dependencies:

dependent tests: (no tests depend on xpickle)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@ShaharNaveh ShaharNaveh marked this pull request as ready for review May 17, 2026 12:44
@youknowone youknowone merged commit 883ce9d into RustPython:main May 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone