Skip to content

Don't skip passing ast tests#7900

Merged
youknowone merged 1 commit into
RustPython:mainfrom
ShaharNaveh:no-skip-ast-tests
May 17, 2026
Merged

Don't skip passing ast tests#7900
youknowone merged 1 commit into
RustPython:mainfrom
ShaharNaveh:no-skip-ast-tests

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented May 17, 2026

ref #7611

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/test/test_ast/test_ast.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 8a8e44b1-abec-48b6-8e82-77b4a2e35b95

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/ast.py
[x] lib: cpython/Lib/_ast_unparse.py
[x] test: cpython/Lib/test/test_unparse.py
[x] test: cpython/Lib/test/test_type_comments.py (TODO: 15)

dependencies:

  • ast

dependent tests: (140 tests)

  • ast: test_ast test_builtin test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_peepholer test_site test_ssl test_type_comments test_ucn test_unparse
    • annotationlib: test_annotationlib test_functools test_inspect test_reprlib test_type_annotations test_type_params test_typing
      • dataclasses: test__colorize test_copy test_ctypes test_enum test_genericalias test_patma test_pprint test_pydoc test_regrtest test_zoneinfo
      • inspect: test_abc test_argparse test_asyncgen test_buffer test_code test_collections test_coroutines test_decimal test_generators test_grammar test_monitoring test_ntpath test_operator test_posixpath test_signal test_sqlite3 test_traceback test_types test_unittest test_yield_from test_zipimport test_zipimport_support
    • dbm.dumb: test_dbm_dumb
    • inspect:
      • bdb: test_bdb
      • cmd: test_cmd
      • importlib.metadata: test_importlib
      • pkgutil: test_pkgutil test_runpy
      • rlcompleter: test_rlcompleter
      • trace: test_trace
      • xmlrpc.server: test_docxmlrpc test_xmlrpc
    • pyclbr: test_pyclbr
    • traceback: test_asyncio test_code_module test_contextlib test_contextlib_async test_dictcomps test_exceptions test_http_cookiejar test_importlib test_iter test_listcomps test_pyexpat test_setcomps test_socket test_subprocess test_sys test_threadedtempfile test_threading test_unittest test_with
      • concurrent.futures.process: test_compileall test_concurrent_futures
      • http.cookiejar: test_urllib2
      • logging: test_asyncio test_hashlib test_logging test_support test_urllib2net
      • multiprocessing: test_asyncio test_concurrent_futures test_fcntl test_memoryview test_multiprocessing_main_handling test_re
      • py_compile: test_cmd_line_script test_importlib test_modulefinder test_py_compile
      • socketserver: test_imaplib test_socketserver test_wsgiref
      • threading: test_android test_asyncio test_bytes test_bz2 test_concurrent_futures test_context test_ctypes test_email test_fork1 test_frame test_ftplib test_gc test_httplib test_httpservers test_importlib test_io test_itertools test_largefile test_linecache test_opcache test_pathlib test_poll test_poplib test_queue test_robotparser test_sched test_smtplib test_super test_syslog test_termios test_threading_local test_time test_urllib2_localnet test_weakref test_winreg test_zstd
      • timeit: test_timeit

[ ] lib: cpython/Lib/shutil.py
[ ] test: cpython/Lib/test/test_shutil.py

dependencies:

  • shutil (native: _winapi, errno, grp, nt, posix, pwd, sys, zlib)
    • collections (native: _collections, _weakref, itertools, sys)
    • warnings (native: _contextvars, _thread, _warnings, builtins, sys)
    • zipfile (native: _path, binascii, importlib.util, itertools, sys, time, zlib)
    • bz2, compression, fnmatch, lzma, os, stat, tarfile

dependent tests: (233 tests)

  • shutil: test_argparse test_bz2 test_compileall test_ctypes test_filecmp test_glob test_httpservers test_importlib test_inspect test_largefile test_launcher test_logging test_modulefinder test_os test_pkgutil test_py_compile test_reprlib test_sax test_shutil test_site test_string_literals test_subprocess test_support test_sysconfig test_tarfile test_tempfile test_traceback test_unicode_file test_venv test_zoneinfo
    • argparse:
      • ast: test_ast test_builtin test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_peepholer test_ssl test_type_comments test_ucn test_unparse
      • calendar: test_calendar test_imaplib test_strftime
      • dis: test__opcode test_code test_compiler_assemble test_dtrace test_monitoring test_opcache test_patma test_positional_only_arg
      • ensurepip: test_ensurepip
      • gzip: test_fileinput test_xmlrpc
      • http.server: test_robotparser test_urllib2_localnet
      • inspect: test_abc test_asyncgen test_buffer test_collections test_coroutines test_decimal test_enum test_functools test_generators test_grammar test_ntpath test_operator test_posixpath test_pydoc test_signal test_sqlite3 test_type_annotations test_types test_typing test_unittest test_yield_from test_zipimport test_zipimport_support
      • mimetypes: test_mimetypes
      • pickle: test_annotationlib test_array test_asyncio test_bool test_bytes test_codecs test_concurrent_futures test_configparser test_csv test_ctypes test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enumerate test_exceptions test_fractions test_genericalias test_http_cookies test_importlib test_io test_ipaddress test_iter test_itertools test_list test_lzma test_memoryio test_memoryview test_minidom test_ordered_dict test_pathlib test_pickle test_picklebuffer test_pickletools test_platform test_plistlib test_posix test_random test_range test_re test_set test_shelve test_slice test_socket test_statistics test_str test_string test_time test_trace test_tuple test_type_aliases test_type_params test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_zipfile test_zlib test_zoneinfo
      • platform: test__locale test__osx_support test_android test_asyncio test_baseexception test_cmath test_ctypes test_fcntl test_math test_regrtest test_strptime test_winreg test_wsgiref
      • py_compile: test_cmd_line_script test_importlib test_multiprocessing_main_handling test_runpy
      • random: test_asyncio test_bisect test_complex test_context test_dbm_dumb test_devpoll test_dummy_thread test_email test_float test_heapq test_hmac test_int test_long test_mmap test_numeric_tower test_poll test_pow test_pprint test_queue test_richcmp test_selectors test_sort test_strtod test_struct test_sys test_thread test_threading test_tokenize test_weakref test_zipfile test_zstd
      • sqlite3.main: test_sqlite3
      • tokenize: test_linecache test_tabnanny
      • webbrowser: test_webbrowser
      • zipapp: test_zipapp
      • zipfile: test_zipfile test_zipfile64
    • ctypes.util: test_ctypes
    • http.server:
      • xmlrpc.server: test_docxmlrpc
    • multiprocessing.util: test_asyncio test_concurrent_futures
    • pathlib: test_dbm_sqlite3 test_importlib test_pathlib test_tomllib test_tools test_winapi
      • importlib: test_bdb test_ctypes test_doctest test_frozen test_hashlib test_importlib test_pyclbr test_sundry
    • tempfile: test_asyncio test_cmd_line test_contextlib test_faulthandler test_importlib test_mailbox test_pkg test_termios test_threadedtempfile test_urllib test_urllib2 test_urllib_response test_winconsoleio
      • urllib.request: test_http_cookiejar test_urllib2net test_urllibnet
    • uuid:
      • wave: test_wave

[ ] lib: cpython/Lib/http
[ ] test: cpython/Lib/test/test_httplib.py (TODO: 2)
[x] test: cpython/Lib/test/test_http_cookiejar.py
[ ] test: cpython/Lib/test/test_http_cookies.py
[x] test: cpython/Lib/test/test_httpservers.py (TODO: 1)

dependencies:

  • http (native: binascii, collections.abc, email.message, email.parser, email.utils, errno, http.client, itertools, pwd, select, sys, time, urllib.parse, urllib.request)
    • shutil, warnings
    • argparse, base64, calendar, contextlib, copy, datetime, enum, html, io, logging, mimetypes, os, posixpath, re, socket, socketserver, ssl, string, subprocess, threading, traceback, types

dependent tests: (46 tests)

  • http: test_docxmlrpc test_genericalias test_hashlib test_http_cookiejar test_http_cookies test_httplib test_httpservers test_logging test_robotparser test_ssl test_ucn test_unicodedata test_urllib test_urllib2 test_urllib2_localnet test_wsgiref test_xml_dom_xmlbuilder test_xmlrpc
    • logging.handlers: test_concurrent_futures test_pkgutil
    • pydoc: test_enum test_pydoc
    • urllib.request: test_pathlib test_sax test_site test_urllib2net test_urllibnet
      • pathlib: test_ast test_dbm_sqlite3 test_ensurepip test_importlib test_launcher test_pathlib test_runpy test_tarfile test_tempfile test_tomllib test_tools test_traceback test_unparse test_venv test_winapi test_zipapp test_zipfile test_zoneinfo test_zstd

[ ] lib: cpython/Lib/zipfile
[x] test: cpython/Lib/test/test_zipfile64.py

dependencies:

  • zipfile

dependent tests: (87 tests)

  • zipfile: test_pkgutil test_shutil test_zipapp test_zipfile test_zipfile64 test_zipimport test_zipimport_support
    • importlib.metadata: test_importlib test_zoneinfo
    • shutil: test_argparse test_bz2 test_compileall test_ctypes test_filecmp test_glob test_httpservers test_importlib test_inspect test_largefile test_launcher test_logging test_modulefinder test_os test_py_compile test_reprlib test_sax test_site test_string_literals test_subprocess test_support test_sysconfig test_tarfile test_tempfile test_traceback test_unicode_file test_venv
      • ctypes.util: test_ctypes
      • ensurepip: test_ensurepip
      • http.server: test_robotparser test_urllib2_localnet test_xmlrpc
      • multiprocessing.util: test_asyncio test_concurrent_futures
      • pathlib: test_ast test_dbm_sqlite3 test_importlib test_pathlib test_runpy test_tomllib test_tools test_unparse test_winapi test_zstd
      • tempfile: test_asyncio test_bytes test_cmd_line test_compile test_concurrent_futures test_contextlib test_csv test_dis test_doctest test_faulthandler test_fileinput test_genericalias test_hashlib test_importlib test_linecache test_mailbox test_ntpath test_pickle test_pkg test_posix test_pydoc test_regrtest test_selectors test_socket test_sys test_tabnanny test_termios test_threadedtempfile test_tokenize test_urllib test_urllib2 test_urllib_response test_winconsoleio
      • webbrowser: test_webbrowser

[ ] lib: cpython/Lib/venv
[x] test: cpython/Lib/test/test_venv.py (TODO: 4)

dependencies:

  • venv (native: _winapi, sys)
    • sysconfig (native: _sysconfig, _winapi, importlib.machinery, importlib.util, os.path, sys)
    • shutil
    • argparse, logging, os, shlex, subprocess, types

dependent tests: (1 tests)

  • venv: test_venv

[ ] lib: cpython/Lib/pickle.py
[ ] lib: cpython/Lib/_compat_pickle.py
[ ] test: cpython/Lib/test/test_pickle.py (TODO: 20)
[ ] test: cpython/Lib/test/test_picklebuffer.py (TODO: 12)
[ ] test: cpython/Lib/test/test_pickletools.py (TODO: 8)
[x] test: cpython/Lib/test/picklecommon.py

dependencies:

  • pickle (native: _pickle, itertools, sys)
    • _compat_pickle
    • _compat_pickle
    • argparse, codecs, copyreg, functools, io, pprint, struct, types

dependent tests: (98 tests)

  • pickle: test_annotationlib test_argparse test_array test_ast test_asyncio test_bool test_builtin test_bytes test_bz2 test_codecs test_collections test_concurrent_futures test_configparser test_coroutines test_csv test_ctypes test_decimal test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enum test_enumerate test_exceptions test_fractions test_functools test_generators test_genericalias test_http_cookies test_importlib test_inspect test_io test_ipaddress test_iter test_itertools test_list test_logging test_lzma test_memoryio test_memoryview test_minidom test_opcache test_operator test_ordered_dict test_os test_pathlib test_pickle test_picklebuffer test_pickletools test_platform test_plistlib test_positional_only_arg test_posix test_random test_range test_re test_set test_shelve test_slice test_socket test_statistics test_str test_string test_time test_trace test_tuple test_type_aliases test_type_params test_types test_typing test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_zipfile test_zlib test_zoneinfo
    • logging: test_asyncio test_concurrent_futures test_hashlib test_pkgutil test_support test_urllib2net
      • asyncio.futures: test_asyncio
      • concurrent.futures._base: test_concurrent_futures
      • hashlib: test_hmac test_smtplib test_tarfile test_unicodedata test_urllib2_localnet
      • http.cookiejar: test_http_cookiejar test_urllib2
      • multiprocessing.util: test_asyncio test_compileall test_concurrent_futures
      • venv: test_venv

[x] lib: cpython/Lib/rlcompleter.py
[ ] test: cpython/Lib/test/test_rlcompleter.py (TODO: 1)

dependencies:

  • rlcompleter

dependent tests: (2 tests)

  • rlcompleter: test_rlcompleter
    • site: test_site

[ ] lib: cpython/Lib/random.py
[x] test: cpython/Lib/test/test_random.py

dependencies:

  • random (native: _random, _sha2, itertools, math, time)
    • warnings
    • _collections_abc, argparse, bisect, hashlib, operator, os, statistics

dependent tests: (129 tests)

  • random: test_asyncio test_bisect test_buffer test_builtin test_bz2 test_collections test_complex test_context test_dbm_dumb test_decimal test_deque test_descr test_devpoll test_dict test_dummy_thread test_email test_float test_functools test_heapq test_hmac test_importlib test_int test_io test_itertools test_logging test_long test_lzma test_math test_mmap test_numeric_tower test_ordered_dict test_poll test_posixpath test_pow test_pprint test_queue test_random test_regrtest test_richcmp test_selectors test_set test_shutil test_signal test_socket test_sort test_statistics test_strtod test_struct test_sys test_tarfile test_thread test_threading test_tokenize test_traceback test_unparse test_uuid test_weakref test_zipfile test_zlib test_zstd
    • email.generator: test_email
      • mailbox: test_genericalias test_mailbox
      • smtplib: test_smtplib test_smtpnet
    • email.utils: test_httpservers test_urllib2
      • http.server: test_robotparser test_urllib2_localnet test_xmlrpc
      • logging.handlers: test_concurrent_futures test_pkgutil
      • urllib.request: test_http_cookiejar test_pathlib test_pydoc test_sax test_site test_ssl test_urllib test_urllib2net test_urllibnet
    • imaplib: test_imaplib
    • secrets: test_secrets
    • tempfile: test_argparse test_ast test_asyncio test_bytes test_cmd_line test_compile test_compileall test_concurrent_futures test_contextlib test_csv test_ctypes test_dis test_doctest test_ensurepip test_faulthandler test_filecmp test_fileinput test_hashlib test_importlib test_inspect test_launcher test_linecache test_modulefinder test_ntpath test_os test_pickle test_pkg test_posix test_py_compile test_runpy test_string_literals test_subprocess test_support test_tabnanny test_tempfile test_termios test_threadedtempfile test_tomllib test_urllib_response test_venv test_winconsoleio test_zipapp test_zipfile64 test_zoneinfo
      • ctypes.util: test_ctypes
    • uuid:
      • wave: test_wave

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@ShaharNaveh ShaharNaveh marked this pull request as ready for review May 17, 2026 12:11
@youknowone youknowone merged commit 723766e into RustPython:main May 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone