crates/stdlib/src/mmap.rs (1)

198-228: 💤 Low value

Consider extracting the common GetSystemInfo pattern.

Both Windows implementations create a SYSTEM_INFO, call GetSystemInfo, and return a field cast to usize. This pattern could be extracted to reduce duplication.

♻️ Optional refactor

+#[cfg(windows)]
+fn get_system_info() -> SYSTEM_INFO {
+    let mut info = SYSTEM_INFO::default();
+    unsafe {
+        GetSystemInfo(&mut info);
+    }
+    info
+}
+
 #[cfg(windows)]
 #[pyattr(name = "PAGESIZE", once)]
 fn page_size(_vm: &VirtualMachine) -> usize {
-    let mut info = SYSTEM_INFO::default();
-    unsafe {
-        GetSystemInfo(&mut info);
-    }
-    info.dwPageSize as _
+    get_system_info().dwPageSize as _
 }

 #[cfg(windows)]
 #[pyattr(name = "ALLOCATIONGRANULARITY", once)]
 fn granularity(_vm: &VirtualMachine) -> usize {
-    let mut info = SYSTEM_INFO::default();
-    unsafe {
-        GetSystemInfo(&mut info);
-    }
-    info.dwAllocationGranularity as _
+    get_system_info().dwAllocationGranularity as _
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/stdlib/src/mmap.rs` around lines 198 - 228, Extract the duplicated
GetSystemInfo pattern into a small helper (e.g., a fn get_system_info() ->
SYSTEM_INFO) and use it from both Windows functions to avoid repeating
allocation and unsafe block: replace the body of page_size and the windows
granularity with calls to this helper and return the appropriate fields
(info.dwPageSize and info.dwAllocationGranularity) cast to usize; keep function
names page_size and granularity and ensure the helper encapsulates the unsafe
GetSystemInfo call and SYSTEM_INFO::default() initialization.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes