Skip to content

Workaround for random windows cache failure#7812

Merged
youknowone merged 1 commit into
RustPython:mainfrom
ShaharNaveh:cache-fail-continue
May 9, 2026
Merged

Workaround for random windows cache failure#7812
youknowone merged 1 commit into
RustPython:mainfrom
ShaharNaveh:cache-fail-continue

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented May 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Until actions/cache#1754 is fixed

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD pipeline robustness on Windows runners by allowing build processes to continue when cache restoration encounters issues.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The PR adds continue-on-error: true to three cache restore steps in the CI workflow to prevent Windows runner crashes from blocking subsequent job steps. The same configuration is applied consistently to rust_tests, snippets_cpython, and clippy jobs.

Changes

CI Workflow Windows Cache Resilience

Layer / File(s) Summary
Windows Cache Restore Tolerance
.github/workflows/ci.yaml		 Cache restore steps in rust_tests, snippets_cpython, and clippy jobs add continue-on-error: true to tolerate Windows runner failures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • RustPython/RustPython#7610: Prior PR switched to explicit cache restore steps; this PR makes those steps non-fatal on Windows runners.

Suggested reviewers

  • fanninpm
  • youknowone

Poem

🐰 On Windows runners where caches crash,
We add a gentle flag, no need to thrash.
continue-on-error: true stands tall,
So workflows proceed, and tests enthrall! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Workaround for random windows cache failure' directly and clearly describes the main change: adding a workaround for intermittent cache failures on Windows runners in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed May 9, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 110-111: Update the comment text in the CI workflow to correct
subject-verb agreement: replace "Windows runners randomly crashes" with "Windows
runners randomly crash" in all three job occurrences (rust_tests,
snippets_cpython, and clippy) so the comment reads correctly alongside the
existing "continue-on-error: true" lines.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4b86cabc-1651-4b0a-bed8-7e9c40fa4c0b

📥 Commits

Reviewing files that changed from the base of the PR and between e10a27b and fc28715.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

Comment thread .github/workflows/ci.yaml
Comment on lines +110 to +111
# Windows runners randomly crashes, https://github.com/actions/cache/issues/1754
continue-on-error: true

@coderabbitai coderabbitai Bot May 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar in comment.

The comment has a subject-verb agreement error: "Windows runners randomly crashes" should be "Windows runners randomly crash" (plural subject requires plural verb).

This appears in three locations (rust_tests, snippets_cpython, and clippy jobs).

📝 Proposed fix

Apply this change to all three occurrences:

-        # Windows runners randomly crashes, https://github.com/actions/cache/issues/1754
+        # Windows runners randomly crash, https://github.com/actions/cache/issues/1754

Also applies to: 330-331, 476-477

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yaml around lines 110 - 111, Update the comment text in
the CI workflow to correct subject-verb agreement: replace "Windows runners
randomly crashes" with "Windows runners randomly crash" in all three job
occurrences (rust_tests, snippets_cpython, and clippy) so the comment reads
correctly alongside the existing "continue-on-error: true" lines.

@youknowone youknowone merged commit 09c27bb into RustPython:main May 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone