Skip to content

Bytecode parity: align borrow optimization with CFG traversal #7773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
May 5, 2026
Merged

Bytecode parity: align borrow optimization with CFG traversal #7773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f8d419
Align CFG cleanup bytecode with CPython
youknowone Apr 28, 2026
a948ac2
remove test
youknowone Apr 30, 2026
7d903de
Bytecode parity: fblock unwind, fstring join, folding, scope
youknowone May 4, 2026
a97fd16
Align borrow optimization with CFG traversal
youknowone May 4, 2026
8dac612
Fix CI lint and comprehension test fallout
youknowone May 4, 2026
e04ca46
Refine CFG scope-exit backedge ordering
youknowone May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,11 @@
"dedentations",
"dedents",
"deduped",
"deoptimized",
"deoptimize",
"emscripten",
"excs",
"fnfe",
"interps",
"jitted",
"jitting",
Expand All @@ -72,6 +74,9 @@
"oparg",
"opargs",
"pyc",
"reborrow",
"reraises",
"reraising",
"significand",
"summands",
"unraisable",
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_coroutines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,6 @@ async def f():
run_async(f()),
([], {1: 1, 2: 2, 3: 3}))

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: __aiter__
def test_nested_comp(self):
async def run_list_inside_list():
return [[i + j async for i in asynciter([1, 2])] for j in [10, 20]]
Expand Down
4 changes: 0 additions & 4 deletions Lib/test/test_peepholer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ def g(a):
self.assertTrue(g(4))
self.check_lnotab(g)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_constant_folding_small_int(self):
tests = [
('(0, )[0]', 0),
Expand Down Expand Up @@ -278,7 +277,6 @@ def test_constant_folding_small_int(self):
self.assertNotInBytecode(code, 'LOAD_SMALL_INT')
self.check_lnotab(code)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: 'UNARY_NEGATIVE' starts with 'UNARY_'
def test_constant_folding_unaryop(self):
intrinsic_positive = 5
tests = [
Expand Down Expand Up @@ -324,7 +322,6 @@ def negzero():
self.assertNotStartsWith(instr.opname, 'UNARY_')
self.check_lnotab(negzero)

@unittest.expectedFailure # TODO: RUSTPYTHON; BINARY_OP 26 ([])
def test_constant_folding_binop(self):
tests = [
('1 + 2', 'NB_ADD', True, 'LOAD_SMALL_INT', 3),
Expand Down Expand Up @@ -672,7 +669,6 @@ def f(x):
return 6
self.check_lnotab(f)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: 2 != 1
def test_assignment_idiom_in_comprehensions(self):
def listcomp():
return [y for x in a for y in [f(x)]]
Expand Down
Loading
Loading