Skip to content

Change dependency groups#7665

Merged
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:dep-groups-update
Apr 24, 2026
Merged

Change dependency groups#7665
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:dep-groups-update

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented Apr 24, 2026 •
edited by coderabbitai Bot
Loading

  • Add ahash to random group
  • Add unix group with nix, mac_address, and rustyline

Summary by CodeRabbit

  • Chores
    • Updated dependency management configuration for automated updates.

Note: This release contains internal infrastructure updates with no visible impact to end-users.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Dependabot configuration updated to include the ahash crate in the existing random grouping and introduces a new unix grouping for Unix-specific dependencies (mac_address, nix, rustyline).

Changes

Cohort / File(s) Summary
Dependabot Configuration
.github/dependabot.yml		 Added ahash to random dependency group; introduced new unix group targeting Unix-specific crates (mac_address, nix, rustyline).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, skip, and a bound—our deps now grouped so sound!
Ahash joins the random cheer, while Unix crates appear,
Mac, nix, and rustyline in bundles so fine,
Dependabot's organization makes this code align! 🔧✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Change dependency groups' directly aligns with the PR's main objective of updating Dependabot dependency groupings in the configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/dependabot.yml (1)

85-85: Move ahash out of the random group for clearer dependency semantics.

ahash is being used as a hash builder (ahash::RandomState) rather than an RNG crate, so grouping it with getrandom/rand/mt19937 makes update batches less coherent.

Proposed grouping tweak 
       random:
         patterns:
-          - "ahash"
           - "getrandom"
           - "mt19937"
           - "rand*"
+      hashing:
+        patterns:
+          - "ahash"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/dependabot.yml at line 85, Remove "ahash" from the dependabot group
that contains random-related crates (the group listing including
"getrandom"/"rand"/"mt19937") and add it to a separate, clearly named group for
hashing utilities (or to the default/group for non-RNG crates); specifically
edit the dependabot group that currently lists "ahash" so that the symbol
"ahash" is no longer present there and instead appears under a new or existing
non-random group (e.g., "hashing" or "utilities") to reflect that ahash provides
ahash::RandomState rather than RNG functionality.
🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/dependabot.yml:
- Line 85: Remove "ahash" from the dependabot group that contains random-related
crates (the group listing including "getrandom"/"rand"/"mt19937") and add it to
a separate, clearly named group for hashing utilities (or to the default/group
for non-RNG crates); specifically edit the dependabot group that currently lists
"ahash" so that the symbol "ahash" is no longer present there and instead
appears under a new or existing non-random group (e.g., "hashing" or
"utilities") to reflect that ahash provides ahash::RandomState rather than RNG
functionality.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9fbbd073-8a64-4da8-805b-15c72a1864a3

📥 Commits

Reviewing files that changed from the base of the PR and between cbfb313 and 6934e20.

📒 Files selected for processing (1)
  • .github/dependabot.yml

@youknowone youknowone merged commit a7ea01a into RustPython:main Apr 24, 2026
20 checks passed
@ShaharNaveh ShaharNaveh mentioned this pull request Apr 24, 2026
Closed
@fanninpm fanninpm deleted the dep-groups-update branch April 24, 2026 23:12
@coderabbitai coderabbitai Bot mentioned this pull request May 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanninpm @youknowone