Skip to content

Fail if prek fails#7574

Open
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:fail-if-prek-fails
Open

Fail if prek fails#7574
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:fail-if-prek-fails

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Apr 9, 2026 •
edited by coderabbitai bot
Loading

https://github.com/RustPython/RustPython/actions/runs/24203032718/job/70651534319?pr=7573
Prek failed but CI passed:/

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD workflow reliability by ensuring linting failures are properly reported instead of being silently ignored, and preventing unnecessary review steps from running when workflows are cancelled.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 6708d9df-d7d6-4040-98d3-8fbc9171723d

📥 Commits

Reviewing files that changed from the base of the PR and between d5a90e5 and 4083416.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

Modified the CI workflow to enforce prek linting failures by removing error continuation, and prevent reviewdog from running when the workflow is cancelled.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/ci.yaml		 Removed continue-on-error: true from prek step to fail on linting errors; added if: ${{ !cancelled() }} condition to reviewdog step to skip execution when workflow is cancelled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The workflow now stands tall and true,
No more errors swept out of view—
When prek finds a flaw, the job will stop,
And if we cancel, reviewdog won't pop!
hops excitedly ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing continue-on-error: true from the prek step so failures are no longer ignored.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ShaharNaveh