Skip to content

Extract shared rustpython-unicode crate and route core Unicode semantics through it #7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Extract shared rustpython-unicode crate and route core Unicode semantics through it #7561

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3af1c5
Initial plan
Copilot Apr 5, 2026
67485b5
Extract shared unicode crate
Copilot Apr 5, 2026
e968d83
Tidy shared unicode review feedback
Copilot Apr 5, 2026
5cf1bd6
Polish unicode regex helpers
Copilot Apr 5, 2026
0a340de
Finish unicode crate follow-up refactors
Copilot Apr 5, 2026
2934897
Polish unicode follow-up review fixes
Copilot Apr 5, 2026
4efa5da
Simplify unicode regex call sites
Copilot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polish unicode follow-up review fixes 
Agent-Logs-Url: https://github.com/RustPython/RustPython/sessions/1d30ae08-d8f0-431c-9299-8aea5c21f7d4

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
  • Loading branch information
@youknowone
Copilot and youknowone authored Apr 5, 2026
commit 2934897035a4a169bd6a669ed59972725e13e64a
2 changes: 1 addition & 1 deletion crates/stdlib/src/unicodedata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ mod unicodedata {
.as_wtf8()
.code_points()
.exactly_one()
.map_err(|_| vm.new_type_error("argument must be an unicode character, not str"))
.map_err(|_| vm.new_type_error("argument must be a Unicode character, not str"))
}
}

Expand Down
5 changes: 3 additions & 2 deletions crates/unicode/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ repository.workspace = true
license.workspace = true

[features]
default = ["casefold"]
casefold = ["dep:caseless"]
default = ["std", "casefold"]
std = []
casefold = ["std", "dep:caseless"]
Copy link
Copy Markdown
Member

@youknowone youknowone Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this feature? when will the feature be disabled?

Copy link
Copy Markdown
Contributor Author

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept the std feature because rustpython-unicode is consumed by no_std crates, while casefold depends on caseless for std-enabled consumers. The feature wiring was clarified in 2934897.


[dependencies]
rustpython-wtf8 = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion crates/unicode/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![cfg_attr(not(feature = "casefold"), no_std)]
#![cfg_attr(not(feature = "std"), no_std)]

extern crate alloc;

Expand Down
Loading