Skip to content

Unify lint CI job #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 19 commits into from
Mar 26, 2026
Merged

Unify lint CI job #7505

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0c9f3e5
use `prek` for unified linting
ShaharNaveh Mar 24, 2026
72fd632
Fix actionlint error
ShaharNaveh Mar 25, 2026
149cc38
Generate metadata when specific files change
ShaharNaveh Mar 25, 2026
e09cf9e
`check_redundant_patches.py` to accept glob path
ShaharNaveh Mar 25, 2026
15b06c2
Test
ShaharNaveh Mar 25, 2026
59a7d2c
revert defective changes
ShaharNaveh Mar 25, 2026
b39ab51
use `rustfmt` over `cargo fmt` for individual files
ShaharNaveh Mar 26, 2026
2f12793
Merge remote-tracking branch 'upstream/main' into ci-lint-unify
ShaharNaveh Mar 26, 2026
c7be0d6
debug reviewdog
ShaharNaveh Mar 26, 2026
4c3b303
rustfmt
ShaharNaveh Mar 26, 2026
3adf498
Move comment to correct location
ShaharNaveh Mar 26, 2026
855eca1
defevtive fmt test
ShaharNaveh Mar 26, 2026
15bdf1f
Fail with reviewdog
ShaharNaveh Mar 26, 2026
cefe51f
fix reviewdog perms
ShaharNaveh Mar 26, 2026
ae898da
Try to use present token
ShaharNaveh Mar 26, 2026
88028e6
without checks oerms
ShaharNaveh Mar 26, 2026
0d52e5e
put normal perms
ShaharNaveh Mar 26, 2026
eefe093
fmt
ShaharNaveh Mar 26, 2026
b2ba0c3
Merge remote-tracking branch 'upstream/main' into ci-lint-unify
ShaharNaveh Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debug reviewdog
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Mar 26, 2026
commit c7be0d6285a4a2680f6477e4785e534aaab61660
11 changes: 8 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,10 +371,12 @@ jobs:
path: ~/.cache/prek

- name: prek
id: prek
uses: j178/prek-action@79f765515bd648eb4d6bb1b17277b7cb22cb6468 # v2.0.0
with:
cache: false
show-verbose-logs: false
continue-on-error: true

- name: save prek cache
if: ${{ github.ref == 'refs/heads/main' }} # only save on main
Expand All @@ -384,11 +386,14 @@ jobs:
path: ~/.cache/prek

- name: reviewdog
if: failure()
uses: reviewdog/action-suggester@aa38384ceb608d00f84b4690cacc83a5aba307ff # 1.24.0
with:
tool_name: prek
fail_level: error
fail_level: none
cleanup: false

- name: fail
if: ${{ steps.prek.outcome == 'failure' }}
run: exit 1

miri:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip:ci') }}
Expand Down
Loading