Skip to content

Resolve shellcheck warning on ci.yaml #7501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Mar 25, 2026
Merged

Resolve shellcheck warning on ci.yaml #7501

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
74c5e4f
Resolve shellcheck warning
ShaharNaveh Mar 24, 2026
a0abcc1
Fix more
ShaharNaveh Mar 24, 2026
4814eeb
Resolve potential template injection
ShaharNaveh Mar 24, 2026
423afb1
Fix logic error
ShaharNaveh Mar 24, 2026
9dc9ebc
Fix
ShaharNaveh Mar 24, 2026
a8bdc23
Remove old
ShaharNaveh Mar 24, 2026
e951998
fix
ShaharNaveh Mar 24, 2026
af1606b
fix
ShaharNaveh Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Mar 24, 2026
commit a8bdc238917db8cfbf20a0b51f98022a96b01b9f
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,7 @@

- name: run cpython tests to check if env polluters have stopped polluting
shell: bash
run: |

Check failure on line 272 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
got unexpected character '@' while lexing expression, expecting 'a'..'z', 'A'..'Z', '_', '0'..'9', ''', '}', '(', ')', '[', ']', '.', '!', '<', '>', '=', '&', '|', '*', ',', ' ' [expression]

Raw Output:
e:.github/workflows/ci.yaml:272:59: got unexpected character '@' while lexing expression, expecting 'a'..'z', 'A'..'Z', '_', '0'..'9', ''', '}', '(', ')', '[', ']', '.', '!', '<', '>', '=', '&', '|', '*', ',', ' ' [expression]
while IFS= read -r thing; do
for thing in "${{ matrix.env_polluting_tests[@] }}"; do
for i in $(seq 1 10); do
set +e
Expand Down
Loading