Skip to content

Pin setup-python action to a commit hash - part 2 #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShaharNaveh wants to merge 4 commits into from
+9 −3
Closed

Pin setup-python action to a commit hash - part 2 #7493

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f28aae
Pin setup-python action to a commit hash
ShaharNaveh Mar 24, 2026
d3f062e
Fix param
ShaharNaveh Mar 24, 2026
2afe19a
Merge remote-tracking branch 'upstream/main' into setup-python-pin-2
ShaharNaveh Mar 25, 2026
4f5dd83
Merge remote-tracking branch 'upstream/main' into setup-python-pin-2
ShaharNaveh Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Pin setup-python action to a commit hash
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Mar 24, 2026
commit 0f28aaee005b32260f87f35fc057dafc2dccb84d
15 changes: 11 additions & 4 deletions .github/workflows/cron-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@

- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@cargo-llvm-cov
- uses: actions/setup-python@v6.2.0

- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}

- run: sudo apt-get update && sudo apt-get -y install lcov
- name: Run cargo-llvm-cov with Rust tests.
run: cargo llvm-cov --no-report --workspace --exclude rustpython_wasm --exclude rustpython-compiler-source --exclude rustpython-venvlauncher --verbose --no-default-features --features stdlib,importlib,encodings,ssl-rustls,jit
Expand All @@ -48,7 +50,8 @@
if: ${{ github.event_name != 'pull_request' }}
uses: codecov/codecov-action@v5
with:
file: ./codecov.lcov
files: |
./codecov.lcov
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

testdata:
name: Collect regression test data
Expand Down Expand Up @@ -96,9 +99,11 @@
persist-credentials: true

- uses: dtolnay/rust-toolchain@stable
- uses: actions/setup-python@v6.2.0

- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: build rustpython
run: cargo build --release --verbose
- name: Collect what is left data
Expand Down Expand Up @@ -157,9 +162,11 @@
persist-credentials: true

- uses: dtolnay/rust-toolchain@stable
- uses: actions/setup-python@v6.2.0

- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}

- run: cargo install cargo-criterion
- name: build benchmarks
run: cargo build --release --benches
Expand All @@ -168,7 +175,7 @@
- name: collect microbenchmarks data
run: cargo criterion --bench microbenchmarks
- name: restructure generated files
run: |

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2185:info:2:1: Some finds don't have a default path. Specify '.' explicitly [shellcheck]

Raw Output:
i:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2185:info:2:1: Some finds don't have a default path. Specify '.' explicitly [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:6:66: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2086:info:6:66: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:6:53: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2086:info:6:53: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:6:59: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2046:warning:6:59: Quote this to prevent word splitting [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2044:warning:6:13: For loops over find output are fragile. Use find -exec or a while read loop [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2044:warning:6:13: For loops over find output are fragile. Use find -exec or a while read loop [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2038:warning:7:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2038:warning:7:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2038:warning:5:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2038:warning:5:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2038:warning:4:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2038:warning:4:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2038:warning:3:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2038:warning:3:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Check warning on line 178 in .github/workflows/cron-ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2038:warning:2:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Raw Output:
w:.github/workflows/cron-ci.yaml:178:9: shellcheck reported issue in this script: SC2038:warning:2:1: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]
cd ./target/criterion/reports
find -type d -name cpython | xargs rm -rf
find -type d -name rustpython | xargs rm -rf
Expand Down
Loading