Skip to content

marshal #7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Mar 23, 2026
Merged

marshal #7467

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce80c08
CPython-compatible marshal format
youknowone Mar 20, 2026
2008055
Address code review: preserve CO_FAST_HIDDEN, fix varint overflow
youknowone Mar 22, 2026
e26c550
Add depth guard to deserialize_value_typed
youknowone Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review: preserve CO_FAST_HIDDEN, fix varint overflow 
- Use original localspluskinds from marshal data instead of
  rebuilding, preserving CO_FAST_HIDDEN and other flags
- Fix write_varint_be to handle values >= 2^30 (add 6th chunk)
- Remove unused build_localspluskinds_from_split
  • Loading branch information
@youknowone
youknowone committed Mar 23, 2026
commit 2008055bd81185f1699795aea8582cee397c7cb0
3 changes: 3 additions & 0 deletions crates/compiler-core/src/varint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ pub fn write_signed_varint(buf: &mut Vec<u8>, val: i32) -> usize {
/// Write a big-endian varint (used by exception tables).
pub fn write_varint_be(buf: &mut Vec<u8>, val: u32) -> usize {
let start_len = buf.len();
if val >= 1 << 30 {
buf.push(0x40 | ((val >> 30) & 0x3f) as u8);
}
if val >= 1 << 24 {
buf.push(0x40 | ((val >> 24) & 0x3f) as u8);
}
Expand Down