Skip to content

A few windows fix #7458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Mar 21, 2026
Merged

A few windows fix #7458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
86a96e7
Disallow instantiation of sys.getwindowsversion type
youknowone Mar 17, 2026
b02cdb6
Remove incorrect WSAHOS errno constant
youknowone Mar 17, 2026
d7d6f7a
Fix mmap resize to raise OSError instead of SystemError
youknowone Mar 17, 2026
24a1719
Fix CreateProcess with empty environment on Windows
youknowone Mar 17, 2026
acb11da
Revert mmap resize error to SystemError and fix errno.rs formatting
youknowone Mar 19, 2026
30e19cd
Fix named mmap resize to raise OSError and unmark test_sleep expected…
youknowone Mar 19, 2026
8b8caca
Use expectedFailureIf for TimeEINTRTest.test_sleep on Linux
youknowone Mar 20, 2026
de0db04
Remove expectedFailure for TimeEINTRTest.test_sleep
youknowone Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CreateProcess with empty environment on Windows 
Empty env dict produced a single null terminator, but
CreateProcessW requires a double null for a valid empty
environment block.
  • Loading branch information
@youknowone
youknowone committed Mar 20, 2026
commit 24a17192a03b1f2b726a749e3cdb24724d86e4e0
1 change: 0 additions & 1 deletion Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,7 +1903,6 @@ def test_run_with_pathlike_path_and_arguments(self):
res = subprocess.run(args)
self.assertEqual(res.returncode, 57)

@unittest.skipIf(mswindows, "TODO: RUSTPYTHON; empty env block fails nondeterministically")
@unittest.skipUnless(mswindows, "Maybe test trigger a leak on Ubuntu")
def test_run_with_an_empty_env(self):
# gh-105436: fix subprocess.run(..., env={}) broken on Windows
Expand Down
5 changes: 5 additions & 0 deletions crates/vm/src/stdlib/_winapi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,11 @@ mod _winapi {
for (_, entry) in entries {
out.push(entry);
}
// Each entry ends with \0, so one more \0 terminates the block.
// For empty env, we need \0\0 as a valid empty environment block.
if out.is_empty() {
out.push_str("\0");
}
out.push_str("\0");
Ok(out.into_vec())
}
Expand Down