Skip to content

Align _opcode_metadata.py to 3.14.3 #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Mar 18, 2026
Merged

Align _opcode_metadata.py to 3.14.3 #7456

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7327b6
Align `_opcode_metadata.py` to 3.14.3
ShaharNaveh Mar 16, 2026
6393ac0
Unmark passing test
ShaharNaveh Mar 17, 2026
e59d6cd
Ensure python 3.14 runs on CI
ShaharNaveh Mar 17, 2026
ba3fde9
Merge remote-tracking branch 'upstream/main' into align-opcode-metadata
ShaharNaveh Mar 17, 2026
cf536b7
Update banner
ShaharNaveh Mar 17, 2026
5f8f38d
Fix `test__opcode.py`
ShaharNaveh Mar 17, 2026
4c9193c
Adjust generate script
ShaharNaveh Mar 17, 2026
2aef7fc
Fix docs
ShaharNaveh Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/pr-format.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ concurrency:
group: format-check-${{ github.event.pull_request.number }}
cancel-in-progress: true

env:
PYTHON_VERSION: "3.14.3"

jobs:
format_check:
permissions:
Expand Down Expand Up @@ -45,6 +48,10 @@ jobs:
- name: Run ruff check import sorting
run: ruff check --select I --fix

- uses: actions/setup-python@v6.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: Run generate_opcode_metadata.py
run: python scripts/generate_opcode_metadata.py

Expand Down
307 changes: 213 additions & 94 deletions Lib/_opcode_metadata.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Lib/test/test__opcode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ def test_is_valid(self):
opcodes = [dis.opmap[opname] for opname in names]
self.check_bool_function_result(_opcode.is_valid, opcodes, True)

@unittest.expectedFailure # TODO: RUSTPYTHON; KeyError: 'BINARY_OP_ADD_INT'
def test_opmaps(self):
def check_roundtrip(name, map):
return self.assertEqual(opcode.opname[map[name]], name)
Expand Down Expand Up @@ -116,7 +115,6 @@ def test_stack_effect_jump(self):


class SpecializationStatsTests(unittest.TestCase):
@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: 'load_attr' not found in []
def test_specialization_stats(self):
stat_names = ["success", "failure", "hit", "deferred", "miss", "deopt"]
specialized_opcodes = [
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_dis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,6 @@ def test_opname(self):
def test_boundaries(self):
self.assertEqual(dis.opmap["EXTENDED_ARG"], dis.EXTENDED_ARG)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: 29 not less than or equal to 20
def test_widths(self):
long_opcodes = set(['JUMP_BACKWARD_NO_INTERRUPT',
'LOAD_FAST_BORROW_LOAD_FAST_BORROW',
Expand Down
Loading
Loading