Skip to content

Implement missing slots for NoneType #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Mar 16, 2026
Merged

Implement missing slots for NoneType #7437

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b31b812
Define only wrapper_descriptor
moreal Mar 15, 2026
6d863fb
Implement missing slots for NoneType
moreal Mar 15, 2026
6a08fda
Unmark fixed tests
moreal Mar 15, 2026
4ababea
Inline PyNone hash value
moreal Mar 15, 2026
07b792b
Improve searchability for NoneType hash value
moreal Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unmark fixed tests
  • Loading branch information
@moreal
moreal committed Mar 15, 2026
commit 6a08fdaf5a7953b9b5e6af94899bbbd961d6ed42
2 changes: 0 additions & 2 deletions Lib/test/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,6 @@ def test_internal_sizes(self):
self.assertGreater(object.__basicsize__, 0)
self.assertGreater(tuple.__itemsize__, 0)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: <method '__lt__' of 'int' objects> is not an instance of <class 'wrapper_descriptor'>
def test_slot_wrapper_types(self):
self.assertIsInstance(object.__init__, types.WrapperDescriptorType)
self.assertIsInstance(object.__str__, types.WrapperDescriptorType)
Expand All @@ -646,7 +645,6 @@ def test_dunder_get_signature(self):
# gh-93021: Second parameter is optional
self.assertIs(sig.parameters["owner"].default, None)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: <built-in method __lt__ of int object at 0xad6c41080> is not an instance of <class 'method-wrapper'>
def test_method_wrapper_types(self):
self.assertIsInstance(object().__init__, types.MethodWrapperType)
self.assertIsInstance(object().__str__, types.MethodWrapperType)
Expand Down
Loading