Skip to content

Remove duplicate cargo check --target x86_64-unknown-freebsd#7377

Merged
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:remove-duplicate-check-bsd
Mar 7, 2026
Merged

Remove duplicate cargo check --target x86_64-unknown-freebsd#7377
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:remove-duplicate-check-bsd

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Mar 7, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Streamlined continuous integration workflow by removing duplicate build configurations and toolchain setup steps, reducing configuration complexity.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 7, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7e4312c8-a9b1-4671-b186-6dabe3669ac0

📥 Commits

Reviewing files that changed from the base of the PR and between ed5bffe and c36d287.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

The .github/workflows/ci.yaml file was updated to remove a dedicated FreeBSD toolchain configuration and its associated compilation check step, eliminating seven lines of FreeBSD-specific logic from the CI pipeline.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yaml		 Removed FreeBSD rust-toolchain setup and dedicated compilation check step, streamlining the workflow by eliminating redundant FreeBSD build configuration.

Poem

🐰 A rabbit hops through workflows bright,
Removing paths that weren't quite right,
FreeBSD's step now fades away,
Simpler pipelines save the day! 🚀

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing a duplicate FreeBSD compilation check from the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ShaharNaveh
ShaharNaveh commented Mar 7, 2026
View reviewed changes
.github/workflows/ci.yaml
@@ -263,13 +263,6 @@ jobs:
- name: Check compilation for freebsd
run: cargo check --target x86_64-unknown-freebsd ${{ env.CARGO_ARGS_NO_SSL }}
Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated of this

@youknowone youknowone merged commit 4aeec7f into RustPython:main Mar 7, 2026
11 of 13 checks passed
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 8, 2026
@ShaharNaveh @youknowone
Remove duplicate cargo check (RustPython#7377)
7b00eb6
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026
@ShaharNaveh
Remove duplicate cargo check (RustPython#7377)
571babd
@coderabbitai coderabbitai bot mentioned this pull request Mar 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone