Skip to content

Tighten specialization guards and add send_none fastpath #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 17 commits into from
Mar 5, 2026
Merged

Tighten specialization guards and add send_none fastpath #7359

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e4abe4a
vm: align specialization guards with CPython patterns
youknowone Mar 5, 2026
1d69c5b
vm: tighten call specialization runtime guards
youknowone Mar 5, 2026
f0a235e
vm: add send_none fastpath for generator specialization
youknowone Mar 5, 2026
e518287
vm: restrict method-descriptor specialization to methods
youknowone Mar 5, 2026
01cdfb5
vm: deopt call specializations on guard misses
youknowone Mar 5, 2026
690921a
vm: match CPython send/for-iter closed-frame guards
youknowone Mar 5, 2026
ed4b7fa
vm: restrict len/isinstance specialization to builtins
youknowone Mar 5, 2026
78dbbb0
vm: use exact-type guards for call specializations
youknowone Mar 5, 2026
01a4c27
vm: align class-call specialization flow with CPython
youknowone Mar 5, 2026
397143b
vm: prefer FAST call opcodes for positional builtin calls
youknowone Mar 5, 2026
41e58d3
vm: add callable identity guard to CALL_LIST_APPEND
youknowone Mar 5, 2026
c694fe1
vm: make CALL_LIST_APPEND runtime guard pointer-based
youknowone Mar 5, 2026
ab82f5b
vm: align call guard cache and fallback behavior with CPython
youknowone Mar 5, 2026
f630d01
vm: use base vectorcall fallback for EXIT-style call misses
youknowone Mar 5, 2026
eeff412
vm: simplify CALL_LEN/CALL_ISINSTANCE runtime guards
youknowone Mar 5, 2026
2a23d3b
vm: infer call-convention flags for CPython-style CALL specialization
youknowone Mar 5, 2026
c7d095a
vm: check use_tracing in eval_frame_active, add SendGen send_none
youknowone Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
vm: simplify CALL_LEN/CALL_ISINSTANCE runtime guards
  • Loading branch information
@youknowone
youknowone committed Mar 5, 2026
commit eeff41296580f202e33bc202f0a179b1209805da
18 changes: 2 additions & 16 deletions crates/vm/src/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4100,14 +4100,7 @@ impl ExecutingFrame<'_> {
let null = self.pop_value_opt();
let callable = self.pop_value();
let callable_ptr = &*callable as *const PyObject as usize;
let is_len_callable = callable
.downcast_ref_if_exact::<PyNativeFunction>(vm)
.is_some_and(|native| {
native.zelf.is_none()
&& native.value.name == "len"
&& native.module.is_some_and(|m| m.as_str() == "builtins")
});
if null.is_none() && cached_ptr == callable_ptr && is_len_callable {
if null.is_none() && cached_ptr == callable_ptr {
let len = obj.length(vm)?;
self.push_value(vm.ctx.new_int(len).into());
return Ok(None);
Expand Down Expand Up @@ -4137,14 +4130,7 @@ impl ExecutingFrame<'_> {
if effective_nargs == 2 {
let callable = self.nth_value(nargs + 1);
let callable_ptr = callable as *const PyObject as usize;
let is_isinstance_callable = callable
.downcast_ref_if_exact::<PyNativeFunction>(vm)
.is_some_and(|native| {
native.zelf.is_none()
&& native.value.name == "isinstance"
&& native.module.is_some_and(|m| m.as_str() == "builtins")
});
if cached_ptr == callable_ptr && is_isinstance_callable {
if cached_ptr == callable_ptr {
let nargs_usize = nargs as usize;
let pos_args: Vec<PyObjectRef> = self.pop_multiple(nargs_usize).collect();
let self_or_null = self.pop_value_opt();
Expand Down