Skip to content

Object header slimming: prefix allocation for ObjExt #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Mar 5, 2026
Merged

Object header slimming: prefix allocation for ObjExt #7334

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3df446
Object header slimming: prefix allocation for ObjExt
youknowone Mar 3, 2026
75d8a3a
Add HAS_WEAKREF to _asyncio Future/Task, rename weakref helpers
youknowone Mar 3, 2026
2ee043e
Add HAS_WEAKREF to array, deque, _grouper; remove expectedFailure mar…
youknowone Mar 3, 2026
de37c01
Add HAS_WEAKREF to code, union, partial, lock, IO, mmap, sre, sqlite3…
youknowone Mar 3, 2026
fb20298
Add HAS_DICT to type flags and handle non-METHOD/CLASS in descr_get
youknowone Mar 4, 2026
a2fe158
Fix ext detection, HeapMethodDef ownership, WASM error
youknowone Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add HAS_WEAKREF to array, deque, _grouper; remove expectedFailure mar… 
…kers

- Add HAS_WEAKREF to PyArray and PyDeque (matches CPython)
- Add HAS_WEAKREF to PyItertoolsGrouper (internal use by groupby)
- Remove 6 expectedFailure markers from test_dataclasses for weakref/slots
  tests that now pass
  • Loading branch information
@youknowone
youknowone committed Mar 5, 2026
commit 2ee043e50287f15703de2345c10bdfe8a7dfc293
6 changes: 0 additions & 6 deletions Lib/test/test_dataclasses/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3672,7 +3672,6 @@ class A:
self.assertEqual(obj.a, 'a')
self.assertEqual(obj.b, 'b')

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_slots_no_weakref(self):
@dataclass(slots=True)
class A:
Expand All @@ -3687,7 +3686,6 @@ class A:
with self.assertRaises(AttributeError):
a.__weakref__

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_slots_weakref(self):
@dataclass(slots=True, weakref_slot=True)
class A:
Expand Down Expand Up @@ -3748,7 +3746,6 @@ def test_weakref_slot_make_dataclass(self):
"weakref_slot is True but slots is False"):
B = make_dataclass('B', [('a', int),], weakref_slot=True)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_weakref_slot_subclass_weakref_slot(self):
@dataclass(slots=True, weakref_slot=True)
class Base:
Expand All @@ -3767,7 +3764,6 @@ class A(Base):
a_ref = weakref.ref(a)
self.assertIs(a.__weakref__, a_ref)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_weakref_slot_subclass_no_weakref_slot(self):
@dataclass(slots=True, weakref_slot=True)
class Base:
Expand All @@ -3785,7 +3781,6 @@ class A(Base):
a_ref = weakref.ref(a)
self.assertIs(a.__weakref__, a_ref)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_weakref_slot_normal_base_weakref_slot(self):
class Base:
__slots__ = ('__weakref__',)
Expand Down Expand Up @@ -3830,7 +3825,6 @@ class B[T2]:
self.assertTrue(B.__weakref__)
B()

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_dataclass_derived_generic_from_base(self):
T = typing.TypeVar('T')

Expand Down
2 changes: 1 addition & 1 deletion crates/stdlib/src/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ mod array {
}

#[pyclass(
flags(BASETYPE),
flags(BASETYPE, HAS_WEAKREF),
with(
Comparable,
AsBuffer,
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/collections.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ mod _collections {
}

#[pyclass(
flags(BASETYPE),
flags(BASETYPE, HAS_WEAKREF),
with(
Constructor,
Initializer,
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/itertools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ mod decl {
groupby: PyRef<PyItertoolsGroupBy>,
}

#[pyclass(with(IterNext, Iterable))]
#[pyclass(with(IterNext, Iterable), flags(HAS_WEAKREF))]
impl PyItertoolsGrouper {}

impl SelfIter for PyItertoolsGrouper {}
Expand Down