Skip to content

Fix symbol table sub_table desync for non-simple annotation targets #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Mar 2, 2026
Merged

Fix symbol table sub_table desync for non-simple annotation targets #7300

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ecdd0c
Fix symbol table sub_table desync for non-simple annotation targets
youknowone Mar 1, 2026
8b61e74
Validate forbidden expressions in non-simple annotation targets
youknowone Mar 2, 2026
8bd6e97
Restore in_annotation flag before propagating error
youknowone Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Restore in_annotation flag before propagating error
  • Loading branch information
@youknowone
youknowone committed Mar 2, 2026
commit 8bd6e976986336061611bda7706265f535167b1f
3 changes: 2 additions & 1 deletion crates/codegen/src/symboltable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,8 +1479,9 @@ impl SymbolTableBuilder {
// (yield, await, named) even for non-simple targets.
let was_in_annotation = self.in_annotation;
self.in_annotation = true;
self.scan_expression(annotation, ExpressionContext::Load)?;
let result = self.scan_expression(annotation, ExpressionContext::Load);
self.in_annotation = was_in_annotation;
result?;
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if let Some(value) = value {
self.scan_expression(value, ExpressionContext::Load)?;
Expand Down
Loading