Skip to content

Optimize fast_locals and atomic ordering #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Mar 1, 2026
Merged

Optimize fast_locals and atomic ordering #7289

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6895ddb
Relax RefCount atomic ordering from SeqCst to Arc pattern
youknowone Mar 1, 2026
89703b6
Reuse existing Vec via prepend_arg in execute_call
youknowone Mar 1, 2026
6a9be9f
Skip downcast_ref checks in invoke when tracing is disabled
youknowone Mar 1, 2026
958853f
Replace fastlocals PyMutex with UnsafeCell-based FastLocals
youknowone Mar 1, 2026
516ff0f
Auto-format: cargo fmt --all
github-actions[bot] Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip downcast_ref checks in invoke when tracing is disabled 
Early return in PyCallable::invoke() when use_tracing is false,
avoiding two downcast_ref type checks on every function call.
  • Loading branch information
@youknowone
youknowone committed Mar 1, 2026
commit 6a9be9f780d5759f4a8c56df5576c5cb5c489108
3 changes: 3 additions & 0 deletions crates/vm/src/protocol/callable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ impl<'a> PyCallable<'a> {

pub fn invoke(&self, args: impl IntoFuncArgs, vm: &VirtualMachine) -> PyResult {
let args = args.into_args(vm);
if !vm.use_tracing.get() {
return (self.call)(self.obj, args, vm);
}
// Python functions get 'call'/'return' events from with_frame().
// Bound methods delegate to the inner callable, which fires its own events.
// All other callables (built-in functions, etc.) get 'c_call'/'c_return'/'c_exception'.
Expand Down