Skip to content

io.TextIoWrapper.reconfigure to always flush #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Mar 1, 2026
Merged

io.TextIoWrapper.reconfigure to always flush #7281

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
954630a
Always flush on reconfigure (io.TextWrapper)
ShaharNaveh Feb 28, 2026
53fca08
Add test
ShaharNaveh Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Always flush on reconfigure (io.TextWrapper)
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Feb 28, 2026
commit 954630a483351ac65ff487f675b4058a7add88cd
11 changes: 3 additions & 8 deletions crates/vm/src/stdlib/io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3029,7 +3029,6 @@ mod _io {
let mut newline_changed = false;
let mut line_buffering = None;
let mut write_through = None;
let mut flush_on_reconfigure = false;

if let Some(enc) = args.encoding {
if enc.as_str().contains('\0') && enc.as_str().starts_with("locale") {
Expand All @@ -3056,11 +3055,9 @@ mod _io {
}

if let OptionalArg::Present(Some(value)) = args.line_buffering {
flush_on_reconfigure = true;
line_buffering = Some(Self::bool_from_index(value, vm)?);
}
if let OptionalArg::Present(Some(value)) = args.write_through {
flush_on_reconfigure = true;
write_through = Some(Self::bool_from_index(value, vm)?);
}

Expand All @@ -3077,12 +3074,10 @@ mod _io {
));
}

if flush_on_reconfigure {
if data.pending.num_bytes > 0 {
data.write_pending(vm)?;
}
vm.call_method(&data.buffer, "flush", ())?;
if data.pending.num_bytes > 0 {
data.write_pending(vm)?;
}
vm.call_method(&data.buffer, "flush", ())?;

if encoding_changed || errors_changed || newline_changed {
if data.pending.num_bytes > 0 {
Expand Down