-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix _hashlib.compare_digest to reject non-ASCII strings #7280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
youknowone
merged 1 commit into
RustPython:main
from
ever0de:fix/hashlib-compare-digest-ascii-check
Mar 1, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 95
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 97
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 2418
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1651
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 2034
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 95
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 197
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 149
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 730
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 2968
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 131
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 206
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1205
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 218
Fix error message to report 'str' instead of the second argument's type.
The error message in the mixed-type case uses
b.as_object().class().name(), which is incorrect. Whenais a string andbis bytes, this produces "a bytes-like object is required, not 'bytes'" which is misleading. CPython always reports "not 'str'" for mixed-type comparisons (bothstr+bytesandbytes+strcases), becausestris the incompatible type. Change the error to report'str'in all mixed-type cases, or dynamically determine which argument isStrand report that type.🤖 Prompt for AI Agents