Skip to content

Don't return frozenset for modules #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Mar 1, 2026
Merged

Don't return frozenset for modules #7276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't return frozenset for modules
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Feb 28, 2026
commit 33c5d84878d4101b0fd04b83b75f94e15612dce2
10 changes: 4 additions & 6 deletions scripts/update_lib/deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self) -> None:
self.__imports = set()

@property
def test_imports(self) -> frozenset[str]:
def test_imports(self) -> set[str]:
imports = set()
for module in self.__imports:
if not module.startswith("test."):
Expand All @@ -48,13 +48,11 @@ def test_imports(self) -> frozenset[str]:

imports.add(name)

return frozenset(imports)
return imports

@property
def lib_imports(self) -> frozenset[str]:
return frozenset(
module for module in self.__imports if not module.startswith("test.")
)
def lib_imports(self) -> set[str]:
return {module for module in self.__imports if not module.startswith("test.")}

def visit_Import(self, node):
for alias in node.names:
Expand Down
Loading