Skip to content

Ensure no warnings on various targets #7245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShaharNaveh wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Ensure no warnings on various targets #7245

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0751dca
Ensure no warnings on various targets
ShaharNaveh Feb 27, 2026
e926bd3
Fix error on android
ShaharNaveh Feb 27, 2026
9755395
More unused imports
ShaharNaveh Feb 27, 2026
51a1c1f
Merge remote-tracking branch 'upstream/main' into disallow-warnings
ShaharNaveh Feb 27, 2026
e006b94
Allow deprecated libc::time_t
ShaharNaveh Feb 27, 2026
5535fc5
More
ShaharNaveh Feb 27, 2026
d7ffb93
more
ShaharNaveh Feb 27, 2026
9728006
More
ShaharNaveh Feb 27, 2026
4d3a8a4
Try to add cfg_attr at struct
ShaharNaveh Feb 27, 2026
c96d15e
Merge remote-tracking branch 'upstream/main' into disallow-warnings
ShaharNaveh Feb 27, 2026
9ffaaa7
Fix for android
ShaharNaveh Feb 27, 2026
6f597bd
Auto-format: ruff format
github-actions[bot] Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Feb 27, 2026
commit d7ffb932e239b7f543aab6d337de0eb8bdcdc41b
3 changes: 3 additions & 0 deletions crates/vm/src/stdlib/os.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,12 +1226,15 @@ pub(super) mod _os {
pub st_gid: PyIntRef,
pub st_size: PyIntRef,
// Indices 7-9: integer seconds
#[cfg_attr(target_env = "musl", allow(deprecated))]
#[pyarg(positional, default)]
#[pystruct_sequence(unnamed)]
pub st_atime_int: libc::time_t,
#[cfg_attr(target_env = "musl", allow(deprecated))]
#[pyarg(positional, default)]
#[pystruct_sequence(unnamed)]
pub st_mtime_int: libc::time_t,
#[cfg_attr(target_env = "musl", allow(deprecated))]
Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matter what I do, the deprecation warning still shows. @youknowone I believe we have a bug related to #[cfg_attr(...)] with #[pystruct_sequence(...)] (and possibly related to when used with #[pyarg(...)])

#[pyarg(positional, default)]
#[pystruct_sequence(unnamed)]
pub st_ctime_int: libc::time_t,
Expand Down