-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Optimize redundant bool check #7176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
youknowone
merged 9 commits into
RustPython:main
from
moreal:optimize-redundant-bool-check
Feb 17, 2026
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
11152d4
Add compile_bool_op_inner and optimize nested opposite-operator BoolO…
moreal 9a2d780
Add snapshot test for nested BoolOp bytecode
moreal d8ccc98
Add runtime test for redundant __bool__ check (issue #3567)
moreal 66cab2c
Apply clippy and rustfmt
moreal a500d54
Apply ruff format
moreal 35706f1
Refactor compile_bool_op: extract emit_short_circuit_test and unify w…
moreal e68c018
Relocate redundant __bool__ check test snippet
moreal dbf95a3
Update extra_tests/snippets/syntax_short_circuit_bool.py
youknowone d6e48ff
Fix assertion in syntax_short_circuit_bool
moreal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
crates/codegen/src/snapshots/rustpython_codegen__compile__tests__nested_bool_op.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.