Skip to content

Update test_ast.py from 3.14.3#7147

Merged
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:update-test-ast
Feb 15, 2026
Merged

Update test_ast.py from 3.14.3#7147
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:update-test-ast

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Feb 14, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

No user-visible changes in this release. This update includes internal code improvements with no impact on functionality or user experience.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 14, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/test/test_ast/test_ast.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Error handling in the PBKDF2-HMAC dklen branch is reformatted. The functionality remains unchanged—len is converted to usize with overflow error handling preserved. Only the map_err chaining and line breaks were adjusted.

Changes

Cohort / File(s) Summary
Error Handling Formatting
crates/stdlib/src/hashlib.rs		 Restructured error handling chain in PBKDF2-HMAC dklen branch; no functional changes to overflow error semantics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops along with glee so bright,
Error chains now formatted right,
Same logic flows, just tidier code,
Down refactoring's pleasant road! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions updating 'test_ast.py from 3.14.3', but the actual changes are to 'crates/stdlib/src/hashlib.rs', reformatting error handling in PBKDF2-HMAC path. The title is unrelated to the actual changeset. Update the PR title to accurately reflect the actual changes, such as 'Reformat error handling in PBKDF2-HMAC dklen branch' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 14, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin update-test-ast

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 15, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/ast.py
[x] lib: cpython/Lib/_ast_unparse.py
[x] test: cpython/Lib/test/test_unparse.py
[x] test: cpython/Lib/test/test_type_comments.py (TODO: 15)

dependencies:

  • ast

dependent tests: (53 tests)

  • ast: test_ast test_builtin test_compile test_dis test_fstring test_future_stmt test_site test_ssl test_type_comments test_ucn test_unparse
    • annotationlib: test_annotationlib test_functools test_inspect test_reprlib test_type_annotations test_type_params test_typing
      • dataclasses: test__colorize test_genericalias test_patma test_pprint test_regrtest test_zoneinfo
      • inspect: test_abc test_argparse test_asyncgen test_buffer test_code test_collections test_coroutines test_decimal test_enum test_generators test_grammar test_ntpath test_operator test_posixpath test_pydoc test_signal test_traceback test_types test_unittest test_yield_from test_zipimport
    • dbm.dumb: test_dbm_dumb
    • inspect:
      • bdb: test_bdb
      • importlib.metadata: test_importlib
      • rlcompleter: test_rlcompleter
      • trace: test_trace
      • xmlrpc.server: test_docxmlrpc test_xmlrpc
    • pyclbr: test_pyclbr

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowone youknowone merged commit fbbd020 into RustPython:main Feb 15, 2026
14 checks passed
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026
@ShaharNaveh
Update test_ast.py from 3.14.3 (RustPython#7147)
f5907c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone