Skip to content

Better codecs and fix lots of test_io and other expectedFailures #6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Feb 6, 2026
Merged

Better codecs and fix lots of test_io and other expectedFailures #6997

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afea165
Fix test_io expectedFailures
youknowone Feb 4, 2026
e948314
Update test_io from v3.14.3
Feb 5, 2026
258ac74
fix io
youknowone Feb 5, 2026
6e09d1b
win codecs
youknowone Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix io
  • Loading branch information
@youknowone
youknowone committed Feb 5, 2026
commit 258ac74384527176cbf8d6c79307a91b2154b1b6
2 changes: 2 additions & 0 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4071,6 +4071,8 @@ def __setstate__(slf, state):
self.assertEqual(newtxt.tag, 'ham')
del MyTextIO

# TODO: RUSTPYTHON; TypeError: a bytes-like object is required, not 'NoneType'
@unittest.expectedFailure
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
def test_read_non_blocking(self):
import os
Expand Down
11 changes: 7 additions & 4 deletions crates/vm/src/stdlib/io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,12 @@ mod _io {

impl Destructor for _IOBase {
fn slot_del(zelf: &PyObject, vm: &VirtualMachine) -> PyResult<()> {
iobase_finalize(zelf, vm);
// C-level IO types (FileIO, Buffered*, TextIOWrapper) have their own
// slot_del that calls iobase_finalize with proper _finalizing flag
// and _dealloc_warn chain. This base fallback is only reached by
// Python-level subclasses, where we silently discard close() errors
// to avoid surfacing unraisables from partially initialized objects.
let _ = vm.call_method(zelf, "close", ());
Ok(())
}

Expand Down Expand Up @@ -4591,10 +4596,8 @@ mod _io {
}

#[pymethod]
fn close(&self, vm: &VirtualMachine) -> PyResult<()> {
drop(self.try_resizable(vm)?);
fn close(&self) {
self.closed.store(true);
Ok(())
}

#[pymethod]
Expand Down