Skip to content

Update pickle.py from 3.14.2 #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 10 commits into from
Feb 5, 2026
Merged

Update pickle.py from 3.14.2 #6982

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9706cec
Update `_compat_pickle.py` from 3.14.2
ShaharNaveh Feb 3, 2026
4b34595
Update `pickle.py` from 3.14.2
ShaharNaveh Feb 3, 2026
af64533
Update pickletools and tests
ShaharNaveh Feb 3, 2026
a530d5a
Update all other pickle related files
ShaharNaveh Feb 3, 2026
8381cc9
Make `test_extcall` to use modified doctest checker
ShaharNaveh Feb 3, 2026
ae4cacb
Merge remote-tracking branch 'upstream/main' into update-compat-pickle
ShaharNaveh Feb 3, 2026
0911855
Restore patch
ShaharNaveh Feb 3, 2026
a65a1e5
Address review
ShaharNaveh Feb 4, 2026
36e18d5
Merge remote-tracking branch 'upstream/main' into update-compat-pickle
ShaharNaveh Feb 4, 2026
a36ab17
Fix grammer
ShaharNaveh Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Feb 4, 2026
commit a65a1e534d895c6938f125746f90db21b3959c61
8 changes: 6 additions & 2 deletions Lib/test/support/rustpython.py
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fanninpm can you please review? I've modified this slightly (renamed the class, and didn't use an if inside the check_output method)

Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@
class DocTestChecker(doctest.OutputChecker):
"""
Custom output checker that lets us to add: `+EXPECTED_FAILURE` for doctest tests.
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar nitpick from a native speaker of English:

Suggested change
Custom output checker that lets us to add: `+EXPECTED_FAILURE` for doctest tests.
Custom output checker that lets us add: `+EXPECTED_FAILURE` for doctest tests.

Also, consider expanding upon what exactly this option string does (allows us to mark doctest examples as currently failing, for accountability).


We want to be able to mark failing doctest test the same way we do with normal
unit test, without this class we would have to skip the doctest for the CI to pass.
"""

def check_output(self, want, got, optionflags):
res = super().check_output(want, got, optionflags)
if optionflags & EXPECTED_FAILURE:
return want != got
return super().check_output(want, got, optionflags)
res = not res
return res