Skip to content

Add __replace__ and fix __reduce__ for structseq #6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Feb 3, 2026
Merged

Add __replace__ and fix __reduce__ for structseq #6978

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b91fa87
Add __replace__ and fix __reduce__ for structseq
youknowone Feb 3, 2026
25ed4f8
Auto-format: cargo fmt --all
github-actions[bot] Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Auto-format: cargo fmt --all
  • Loading branch information
@github-actions
github-actions[bot] committed Feb 3, 2026
commit 25ed4f82d72a4bb7ed6f02e17f6588f6d5341a26
9 changes: 3 additions & 6 deletions crates/vm/src/types/structseq.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
)));
}

let n_fields = Self::Data::REQUIRED_FIELD_NAMES.len()
+ Self::Data::OPTIONAL_FIELD_NAMES.len();
let n_fields =
Self::Data::REQUIRED_FIELD_NAMES.len() + Self::Data::OPTIONAL_FIELD_NAMES.len();
let mut items: Vec<PyObjectRef> = zelf.as_slice()[..n_fields].to_vec();

let mut kwargs = args.kwargs.clone();
Expand All @@ -268,10 +268,7 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
// Check for unexpected keyword arguments
if !kwargs.is_empty() {
let names: Vec<&str> = kwargs.keys().map(|k| k.as_str()).collect();
return Err(vm.new_type_error(format!(
"Got unexpected field name(s): {:?}",
names
)));
return Err(vm.new_type_error(format!("Got unexpected field name(s): {:?}", names)));
}

PyTuple::new_unchecked(items.into_boxed_slice())
Expand Down
Loading