Skip to content

Update _ast_unparse and fix unparse, type_comments #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Feb 3, 2026
Merged

Update _ast_unparse and fix unparse, type_comments #6961

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
400696c
--exclude rustpython-venvlauncher
youknowone Feb 3, 2026
0da5931
fix unparse
youknowone Feb 1, 2026
1876ac8
Fix compiler panics
youknowone Feb 2, 2026
63bbb3c
fix ast fields including type_comments
youknowone Feb 2, 2026
69c19f7
Update _ast_unparse from v3.14.2
Feb 1, 2026
ff49bfe
mark ast & test_genericalias
youknowone Feb 2, 2026
00cdb30
Fix AST field defaults and compile() type check
youknowone Feb 2, 2026
9e7faba
Auto-format: cargo fmt --all
github-actions[bot] Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Auto-format: cargo fmt --all
  • Loading branch information
@github-actions
github-actions[bot] committed Feb 3, 2026
commit 9e7faba7f3e3e4c86815c8a3f40b191e39d4920a
2 changes: 1 addition & 1 deletion crates/vm/src/protocol/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ impl PyObject {

if let Some(class_getitem) =
vm.get_attribute_opt(self.to_owned(), identifier!(vm, __class_getitem__))?
&& !vm.is_none(&class_getitem)
&& !vm.is_none(&class_getitem)
{
return class_getitem.call((needle,), vm);
}
Expand Down
5 changes: 1 addition & 4 deletions crates/vm/src/stdlib/ast/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,7 @@ pub(crate) mod _ast {
let is_list_field = if field_name == "args" {
class_name == "Call" || class_name == "arguments"
} else if field_name == "body" || field_name == "orelse" {
!matches!(
class_name.as_str(),
"Lambda" | "Expression" | "IfExp"
)
!matches!(class_name.as_str(), "Lambda" | "Expression" | "IfExp")
} else {
LIST_FIELDS.contains(&field_name)
};
Expand Down
16 changes: 7 additions & 9 deletions crates/vm/src/stdlib/builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,13 @@ mod builtins {

// compile(ast_node, ..., PyCF_ONLY_AST) returns the AST after validation
if is_ast_only {
let (expected_type, expected_name) = ast::mode_type_and_name(
&vm.ctx, mode_str,
)
.ok_or_else(|| {
vm.new_value_error(
"compile() mode must be 'exec', 'eval', 'single' or 'func_type'"
.to_owned(),
)
})?;
let (expected_type, expected_name) = ast::mode_type_and_name(&vm.ctx, mode_str)
.ok_or_else(|| {
vm.new_value_error(
"compile() mode must be 'exec', 'eval', 'single' or 'func_type'"
.to_owned(),
)
})?;
if !args.source.fast_isinstance(&expected_type) {
return Err(vm.new_type_error(format!(
"expected {} node, got {}",
Expand Down
Loading