Skip to content

add --compile-only flag for syntax/compile validation #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jawfish wants to merge 7 commits into from
Closed

add --compile-only flag for syntax/compile validation #6943

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
acc69e6
add --compile-only cli flag and runmode variant
Jawfish Feb 1, 2026
65f8f1e
implement compile-only mode handler
Jawfish Feb 1, 2026
ab1d681
add unit test for compile-only mode
Jawfish Feb 1, 2026
0fd1523
Merge branch 'main' into add-compile-only-flag
Jawfish Feb 1, 2026
b9d1330
fix --compile-only option termination
Jawfish Feb 1, 2026
2ad616c
exit non-zero when no files specified
Jawfish Feb 1, 2026
dde30cd
add docstring for compileonly variant
Jawfish Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix --compile-only option termination
  • Loading branch information
@Jawfish
Jawfish committed Feb 1, 2026
commit b9d1330f351d89665e08eddd6aec51b14d09153a
22 changes: 8 additions & 14 deletions src/settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ struct CliArgs {
warning_control: Vec<String>,
implementation_option: Vec<String>,
check_hash_based_pycs: CheckHashPycsMode,
compile_only: bool,

#[cfg(feature = "flame-it")]
profile_output: Option<std::ffi::OsString>,
Expand Down Expand Up @@ -153,7 +152,13 @@ fn parse_args() -> Result<(CliArgs, RunMode, Vec<String>), lexopt::Error> {
Long("check-hash-based-pycs") => {
args.check_hash_based_pycs = parser.value()?.parse()?
}
Long("compile-only") => args.compile_only = true,
Long("compile-only") => {
let files: Vec<String> = parser
.raw_args()?
.map(|a| a.string())
.collect::<Result<_, _>>()?;
return Ok((args, RunMode::CompileOnly(files), vec![]));
}

// TODO: make these more specific
Long("help-env") => help(parser),
Expand Down Expand Up @@ -183,13 +188,6 @@ fn parse_args() -> Result<(CliArgs, RunMode, Vec<String>), lexopt::Error> {
}
Value(script_name) => {
let script_name = script_name.string()?;
if args.compile_only {
return Ok((
args,
RunMode::CompileOnly(argv(script_name, parser)?),
vec![],
));
}
let mode = if script_name == "-" {
RunMode::Repl
} else {
Expand All @@ -200,11 +198,7 @@ fn parse_args() -> Result<(CliArgs, RunMode, Vec<String>), lexopt::Error> {
_ => return Err(arg.unexpected()),
}
}
if args.compile_only {
Ok((args, RunMode::CompileOnly(vec![]), vec![]))
} else {
Ok((args, RunMode::Repl, vec![]))
}
Ok((args, RunMode::Repl, vec![]))
}

fn help(parser: lexopt::Parser) -> ! {
Expand Down