Skip to content

posix.link, termios.error, warn() error, closefd=False for std in/out #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Feb 1, 2026
Merged

posix.link, termios.error, warn() error, closefd=False for std in/out #6942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24b6f48
Add follow_symlinks support to os.link()
youknowone Feb 1, 2026
188d438
Use new_os_subtype_error for termios error construction
youknowone Feb 1, 2026
fce2d78
Propagate errors from warnings.warn() calls
youknowone Feb 1, 2026
1132f66
Set closefd=false for stdio file objects in VM init
youknowone Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use new_os_subtype_error for termios error construction 
- Replace manual exception creation with new_os_subtype_error in termios
- Remove redundant .to_owned() calls in os.link() error messages
  • Loading branch information
@youknowone
youknowone committed Feb 1, 2026
commit 188d438e00741dccda8484576b03041aa5ca4d61
9 changes: 4 additions & 5 deletions crates/stdlib/src/termios.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,12 @@ mod termios {
}

fn termios_error(err: std::io::Error, vm: &VirtualMachine) -> PyBaseExceptionRef {
vm.new_exception(
vm.new_os_subtype_error(
error_type(vm),
vec![
err.posix_errno().to_pyobject(vm),
vm.ctx.new_str(err.to_string()).into(),
],
Some(err.posix_errno()),
vm.ctx.new_str(err.to_string()),
)
.upcast()
}

#[pyattr(name = "error", once)]
Expand Down
6 changes: 3 additions & 3 deletions crates/vm/src/stdlib/os.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,9 +1278,9 @@ pub(super) mod _os {
{
use std::os::unix::ffi::OsStrExt;
let src_cstr = std::ffi::CString::new(src.path.as_os_str().as_bytes())
.map_err(|_| vm.new_value_error("embedded null byte".to_owned()))?;
.map_err(|_| vm.new_value_error("embedded null byte"))?;
let dst_cstr = std::ffi::CString::new(dst.path.as_os_str().as_bytes())
.map_err(|_| vm.new_value_error("embedded null byte".to_owned()))?;
.map_err(|_| vm.new_value_error("embedded null byte"))?;

let flags = if follow_symlinks.0 {
libc::AT_SYMLINK_FOLLOW
Expand Down Expand Up @@ -1315,7 +1315,7 @@ pub(super) mod _os {
// or raise NotImplementedError if explicitly set to False
if !follow_symlinks.0 {
return Err(vm.new_not_implemented_error(
"link: follow_symlinks unavailable on this platform".to_owned(),
"link: follow_symlinks unavailable on this platform",
));
}

Expand Down