Skip to content

Depend on serde_core instead of serde#6872

Merged
youknowone merged 1 commit into
RustPython:mainfrom
coolreader18:serde_core
Jan 26, 2026
Merged

Depend on serde_core instead of serde#6872
youknowone merged 1 commit into
RustPython:mainfrom
coolreader18:serde_core

Conversation

@coolreader18
Copy link
Copy Markdown
Member

@coolreader18 coolreader18 commented Jan 25, 2026 •
edited by coderabbitai Bot
Loading

This makes it so if a dependent crate enables the derive feature of serde, serde_derive will be able to be built at the same time as rustpython.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies for compatibility improvements.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 25, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The serde dependency in Cargo.toml has been updated to use serde_core as a package alias, while adding the alloc feature flag. The version and default-features = false setting remain unchanged.

Changes

Cohort / File(s) Summary
Dependency Configuration
Cargo.toml		 Updated serde dependency: changed package reference to serde_core, added features = ["alloc"]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker-twitch of dependency cheer,
From serde to serde_core, loud and clear!
With alloc features bright, the change is done,
One little line, but the work is fun! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Depend on serde_core instead of serde' accurately and concisely summarizes the main change in the pull request, which is switching the serde dependency to serde_core in Cargo.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone merged commit 0a9d41d into RustPython:main Jan 26, 2026
13 checks passed
@coolreader18 coolreader18 deleted the serde_core branch January 26, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coolreader18 @youknowone