-
Notifications
You must be signed in to change notification settings - Fork 1.4k
update_lib todo also shows test todo #6859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
544ff28
show todo
youknowone b842907
`update_lib todo` also shows test todo
youknowone 29607ef
Auto-format: ruff format
github-actions[bot] 6daabf8
show lib when test is not done
youknowone fe61dd1
show untracked files
youknowone 968771d
_ast_unparse
youknowone 7af6bbd
better auto detection
youknowone 7096b76
Auto-format: ruff format
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring does not match implementation.
The docstring states scores of
0,1, and-1, but the implementation uses0,2, and1:score = 0: lib is up-to-date (matches)score = 2: lib NOT up-to-date (docstring says1)score = 1: no corresponding lib (docstring says-1)📝 Proposed fix
"""Compute prioritized list of tests to update. Scoring: - - If corresponding lib is up-to-date: score = 0 (ready) - - If corresponding lib is NOT up-to-date: score = 1 (wait for lib) - - If no corresponding lib: score = -1 (independent) + - If corresponding lib is up-to-date: score = 0 (ready to update) + - If no corresponding lib: score = 1 (independent test) + - If corresponding lib is NOT up-to-date: score = 2 (wait for lib first) Returns: List of dicts with test info, sorted by priority """📝 Committable suggestion
🤖 Prompt for AI Agents