Skip to content

improve deps CI formatting and name resolution #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Jan 23, 2026
+133 −17
Merged

improve deps CI formatting and name resolution #6847

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d70e3e
show `-`
youknowone Jan 23, 2026
0d38949
markdown section
youknowone Jan 23, 2026
eee2932
smarter module resolution
youknowone Jan 23, 2026
47a6de0
Fix CI comment
youknowone Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix CI comment
  • Loading branch information
@youknowone
youknowone committed Jan 23, 2026
commit 47a6de039bb3fd080a1a970e4fa704dddde33940
16 changes: 11 additions & 5 deletions .github/workflows/lib-deps-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,20 @@ jobs:
echo "Changed files:"
echo "$changed"

# Extract unique module names (top-level only, skip test/)
# Extract unique module names
modules=""
for file in $changed; do
# Skip test files
if [[ "$file" == Lib/test/* ]]; then
continue
# Test files: Lib/test/test_pydoc.py -> test_pydoc, Lib/test/test_pydoc/foo.py -> test_pydoc
module=$(echo "$file" | sed -E 's|^Lib/test/||; s|\.py$||; s|/.*||')
# Skip non-test files in test/ (e.g., support.py, __init__.py)
if [[ ! "$module" == test_* ]]; then
continue
fi
else
# Lib files: Lib/foo.py -> foo, Lib/foo/__init__.py -> foo
module=$(echo "$file" | sed -E 's|^Lib/||; s|/__init__\.py$||; s|\.py$||; s|/.*||')
fi
# Extract module name: Lib/foo.py -> foo, Lib/foo/__init__.py -> foo
module=$(echo "$file" | sed -E 's|^Lib/||; s|/__init__\.py$||; s|\.py$||; s|/.*||')
if [[ -n "$module" && ! " $modules " =~ " $module " ]]; then
modules="$modules $module"
fi
Expand Down Expand Up @@ -94,6 +99,7 @@ jobs:
with:
header: lib-deps-check
number: ${{ github.event.pull_request.number }}
recreate: true
message: |
## 📦 Library Dependencies

Expand Down
Loading