Skip to content

Introduce /upgrade-pylib-next #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Jan 30, 2026
Merged

Introduce /upgrade-pylib-next #6827

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6b3e342
Simplify upgrade-pylib.md by removing manual copy steps handled by qu…
moreal Jan 21, 2026
70e7a6d
Let upgrade-pylib run auto-mark instead marking manually
moreal Jan 21, 2026
37bdfd6
Let upgrade-pylib a separate commit from updating module
moreal Jan 21, 2026
35ceed8
Correct commands' permissions
moreal Jan 21, 2026
79babbc
Add open PR check to upgrade-pylib-next command
moreal Jan 21, 2026
cd1389b
Fix dependency pattern example in upgrade-pylib-next command
moreal Jan 21, 2026
b2c93ca
Let upgrade-pylib command to invetigate failing tests
moreal Jan 21, 2026
2712f2b
Add pre-commit review to invetigate-test-failure command
moreal Jan 23, 2026
01c614d
Use deps command to get dependent tests in upgrade-pylib workflow
moreal Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add pre-commit review to invetigate-test-failure command
  • Loading branch information
@moreal
moreal committed Jan 30, 2026
commit 2712f2b2b391d24db69afd4aad1413ae7be0ddc0
12 changes: 10 additions & 2 deletions .claude/commands/investigate-test-failure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
allowed-tools: Bash(python3:*), Bash(cargo run:*), Read, Grep, Glob, Bash(git add:*), Bash(git commit:*)
allowed-tools: Bash(python3:*), Bash(cargo run:*), Read, Grep, Glob, Bash(git add:*), Bash(git commit:*), Bash(cargo fmt:*), Bash(git diff:*), Task
---

# Investigate Test Failure
Expand All @@ -21,9 +21,17 @@ Investigate why a specific test is failing and determine if it can be fixed or n
- Document the expected output

3. **Determine fix feasibility**
- **Simple fix** (import issues, small logic bugs): Fix and commit
- **Simple fix** (import issues, small logic bugs): Fix code → Run `cargo fmt --all` → Pre-commit review → Commit
- **Complex fix** (major unimplemented features): Collect issue info and report to user

**Pre-commit review process**:
- Run `git diff` to see the changes
- Use Task tool with `general-purpose` subagent to review:
- Compare implementation against cpython/ source code
- Verify the fix aligns with CPython behavior
- Check for any missed edge cases
- Proceed to commit only after review passes

4. **For complex issues - Collect issue information**
Following `.github/ISSUE_TEMPLATE/report-incompatibility.md` format:

Expand Down