-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Await fsm checkpoint #6765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Await fsm checkpoint #6765
Changes from 1 commit
e9a70c7
68da611
1bf2bdf
1726b36
fd57302
ecfabb8
bc9b80a
1a1c97a
3997507
551d025
665790f
c2edc6b
4dc6120
9ac5e54
8ea2822
66dc584
6c26391
a1c1891
f41b080
5f547a5
3ed0799
9704677
965b201
9f354c2
b50f1f3
f8fc889
26ac488
b2ba6ea
2dfed2d
d8aabdd
6d54427
a1a7ec6
3620c13
fe31a3d
8eaf89f
5544761
13117d6
63c44b5
c6806af
9844d0d
a07fed6
06e9e6a
072c0cc
5e01466
b9dc39d
d5afdde
9f3c462
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Introduced a new section in `Cargo.toml` for PVM versioning, setting the current version to "0.0.2". - Updated `build.rs` to read the PVM version from the environment or `Cargo.toml`, enhancing build configuration. - Modified `version.rs` to include the PVM version in the output format for better clarity in version reporting.
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -31,10 +31,13 @@ pub fn get_version() -> String { | |||||||||||||||||||||||||||
| #[cfg(not(windows))] | ||||||||||||||||||||||||||||
| let msc_info = String::new(); | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| let pvm_version = env!("PVM_VERSION"); | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| format!( | ||||||||||||||||||||||||||||
| "{:.80} ({:.80}) \nPVM 0.0.2 based on RustPython {} with {:.80}{}", // \n is PyPy convention | ||||||||||||||||||||||||||||
| "{:.80} ({:.80}) \nPVM VERSION {} , based on RustPython {} with {:.80}{}", // \n is PyPy convention | ||||||||||||||||||||||||||||
| get_version_number(), | ||||||||||||||||||||||||||||
| get_build_info(), | ||||||||||||||||||||||||||||
| pvm_version, | ||||||||||||||||||||||||||||
| env!("CARGO_PKG_VERSION"), | ||||||||||||||||||||||||||||
|
Comment on lines
36
to
41
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix minor output typo ("{} ,"). There’s an extra space before the comma in the version string. 📝 Suggested fix- "{:.80} ({:.80}) \nPVM VERSION {} , based on RustPython {} with {:.80}{}", // \n is PyPy convention
+ "{:.80} ({:.80}) \nPVM VERSION {}, based on RustPython {} with {:.80}{}", // \n is PyPy convention📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||
| COMPILER, | ||||||||||||||||||||||||||||
| msc_info, | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make version parsing robust to comments and single quotes.
The current parsing will include inline comments or single quotes in the version string.
🔧 Suggested fix
🤖 Prompt for AI Agents