Skip to content

fix symtable for named_expressions #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 31, 2025
Merged

fix symtable for named_expressions #6604

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03cf6e6
check duplicated type parameter
youknowone Dec 31, 2025
93abd3b
typealias
youknowone Dec 31, 2025
767c3e6
fix self.in_comp_inner_loop_target
youknowone Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
check duplicated type parameter
  • Loading branch information
@youknowone
youknowone committed Dec 31, 2025
commit 03cf6e6c5329c26405fcf8e3059ff67c3a4c13bf
20 changes: 20 additions & 0 deletions crates/codegen/src/symboltable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,6 +1472,26 @@ impl SymbolTableBuilder {
}

fn scan_type_params(&mut self, type_params: &TypeParams) -> SymbolTableResult {
// Check for duplicate type parameter names
let mut seen_names: std::collections::HashSet<&str> = std::collections::HashSet::new();
for type_param in &type_params.type_params {
let (name, range) = match type_param {
TypeParam::TypeVar(tv) => (tv.name.as_str(), tv.range),
TypeParam::ParamSpec(ps) => (ps.name.as_str(), ps.range),
TypeParam::TypeVarTuple(tvt) => (tvt.name.as_str(), tvt.range),
};
if !seen_names.insert(name) {
return Err(SymbolTableError {
error: format!("duplicate type parameter '{}'", name),
location: Some(
self.source_file
.to_source_code()
.source_location(range.start(), PositionEncoding::Utf8),
),
});
}
}

// Register .type_params as a type parameter (automatically becomes cell variable)
self.register_name(".type_params", SymbolUsage::TypeParam, type_params.range)?;

Expand Down